[MD settings] removing a11y_page.css to unify settings styles further

[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048
Committed: https://crrev.com/d81338f3e8bc39f12fa2026550c1af7a93a5a7e0
Cr-Commit-Position: refs/heads/master@{#371673}

[dschuyler, 2016-01-23 02:27:54]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[Dan Beam, 2016-01-25 18:54:07]

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared.css:31: span + a {
why not span ~ a?

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared.css:116: .settings-box[row] {
why are you using an attribute here but classes otherwise?

[dschuyler, 2016-01-26 20:14:19]

Description was changed from

==========
[MD settings] removing a11y_page.css to unify settings styles further

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

BUG=537048
==========

to

==========
[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048
==========

[dschuyler, 2016-01-26 22:16:35]

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared.css:31: span + a {
On 2016/01/25 18:54:07, Dan Beam wrote:
> why not span ~ a?

Either will work in this case.  '+' has the draw
back that multiple <a> in the same line may not
get the styling.  '~' has the draw back that <a>
at the start of a following line (say after a <br>)
will get unwanted styling.  Neither of those
drawbacks currently apply though.

Done.

https://codereview.chromium.org/1628633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared.css:116: .settings-box[row] {
On 2016/01/25 18:54:07, Dan Beam wrote:
> why are you using an attribute here but classes otherwise?

I didn't recall the subtle difference between
the selectors
.foo .bar
and
.foo.bar
that allow a combination of classes to be
detected, so I was hacking it with an attribute.
Thanks!  They are now both classes.

Done.

[dpapad, 2016-01-26 23:07:52]

lgtm

[dschuyler, 2016-01-27 00:53:15]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-01-27 00:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1628633002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1628633002/60001

[commit-bot: I haz the power, 2016-01-27 01:24:54]

Description was changed from

==========
[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048
==========

to

==========
[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048
==========

[commit-bot: I haz the power, 2016-01-27 01:24:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-27 01:26:30]

Description was changed from

==========
[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048
==========

to

==========
[MD settings] removing a11y_page.css; adding .first and .vertical-list

This CL removes a .css file that is no longer needed.  This
brings us closer to unifying the MD settings and helps migrate
away from the deprecated css import.

The .settings-box:first-of-type has been replaced by .first
or .vertical-list.  The .vertical-list is used with is="dom-repeat"
and .first is used where the the first element of the list
is explicit (rather than generated at run time).

BUG=537048

Committed: https://crrev.com/d81338f3e8bc39f12fa2026550c1af7a93a5a7e0
Cr-Commit-Position: refs/heads/master@{#371673}
==========

[commit-bot: I haz the power, 2016-01-27 01:26:31]

Patchset 4 (id:??) landed as
https://crrev.com/d81338f3e8bc39f12fa2026550c1af7a93a5a7e0
Cr-Commit-Position: refs/heads/master@{#371673}