pkg/analysis_server/lib/src/services/refactoring/inline_method.dart - Issue 1628623002: Isse 25404. When remove a method during inlining, remove also leading empty lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

Issue 1628623002: Isse 25404. When remove a method during inlining, remove also leading empty lines. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | pkg/analysis_server/test/services/refactoring/inline_method_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

index 4b6140cbb1620a7781bb7351037ecaf0969c05e8..125c7baec464991c4c283060ecbe46e44fbdb7a6 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

@@ -263,7 +263,8 @@ class InlineMethodRefactoringImpl extends RefactoringImpl

// delete method

if (deleteSource && inlineAll) {

SourceRange methodRange = rangeNode(_methodNode);

- SourceRange linesRange = _methodUtils.getLinesRange(methodRange);

+ SourceRange linesRange =

+ _methodUtils.getLinesRange(methodRange, skipLeadingEmptyLines: true);

doSourceChange_addElementEdit(

change, _methodElement, newSourceEdit_range(linesRange, ''));

}