Issue 1628623002: Isse 25404. When remove a method during inlining, remove also leading empty lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1628623002: Isse 25404. When remove a method during inlining, remove also leading empty lines. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -4 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/strings.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	3 chunks	+28 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/inline_method.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/inline_method_test.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 11 months ago (2016-01-23 03:40:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fe7a48d6c7a24a099505a2f216b02b293235d709 (presubmit successful).