Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/autofill/browser/autofill_driver.h

Issue 16286020: Abstract WebContentsObserver from Autofill shared code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Nit Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_driver.h
diff --git a/components/autofill/browser/autofill_driver.h b/components/autofill/browser/autofill_driver.h
new file mode 100644
index 0000000000000000000000000000000000000000..3bcd2319ba6857c2ba0e09ac34b5fbbb91022077
--- /dev/null
+++ b/components/autofill/browser/autofill_driver.h
@@ -0,0 +1,26 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_DRIVER_H_
+#define COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_DRIVER_H_
+
+namespace content {
+class WebContents;
+}
+
+namespace autofill {
+
+// Interface that provides access to the driver-level context in which autofill
Ilya Sherman 2013/06/12 00:07:46 nit: "autofill" -> "Autofill" (feature name)
blundell 2013/06/12 16:29:37 Done.
+// is operating. A concrete implementation must be provided by the driver.
+class AutofillDriver {
blundell 2013/06/11 15:35:47 I envision this interface being the one that will
Ilya Sherman 2013/06/12 00:07:46 AutofillDriver sounds fine to me. If the interfac
blundell 2013/06/12 16:29:37 SGTM. On 2013/06/12 00:07:46, Ilya Sherman wrote:
+ public:
+ // TODO(blundell): Remove this method once shared code no longer needs to
+ // know about WebContents.
+ virtual content::WebContents* GetWebContents() = 0;
+ virtual ~AutofillDriver() {}
Ilya Sherman 2013/06/12 00:07:46 nit: Destructor belongs above other methods.
blundell 2013/06/12 16:29:37 Done.
+};
+
+} // namespace autofill
+
+#endif // COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_DRIVER_H_

Powered by Google App Engine
This is Rietveld 408576698