chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc - Issue 16286020: Abstract WebContentsObserver from Autofill shared code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc

Issue 16286020: Abstract WebContentsObserver from Autofill shared code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to fix conflict Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_delegate_impl.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc

index a9bc9dce7f77291e644066e4a962f0449d1934bf..f9bd96b3272921b7b4e7809c19792ebb8fbab7a4 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc

@@ -11,6 +11,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "components/autofill/browser/autofill_manager.h"

#include "components/autofill/browser/test_autofill_external_delegate.h"

+#include "components/autofill/content/browser/autofill_driver_impl.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_observer.h"

#include "content/public/test/test_utils.h"

@@ -77,7 +78,8 @@ class AutofillPopupControllerBrowserTest

autofill_external_delegate_.reset(

new TestAutofillExternalDelegate(

web_contents_,

- AutofillManager::FromWebContents(web_contents_)));

+ AutofillDriverImpl::FromWebContents(

+ web_contents_)->autofill_manager()));

}

// Normally the WebContents will automatically delete the delegate, but here