components/autofill/browser/test_autofill_driver.cc - Issue 16286020: Abstract WebContentsObserver from Autofill shared code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/browser/test_autofill_driver.cc

Issue 16286020: Abstract WebContentsObserver from Autofill shared code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Nit Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	Ilya Sherman 2013/06/12 00:07:46 ultra nit: Please omit the "(c)" ultra nit: Please omit the "(c)" blundell 2013/06/12 16:29:37 Done. Show quoted text On 2013/06/12 00:07:46, Ilya Sherman wrote: > ultra nit: Please omit the "(c)" Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/autofill/browser/test_autofill_driver.h"

	6

	7 namespace autofill {

	8

	9 TestAutofillDriver::TestAutofillDriver(content::WebContents* web_contents)

	10 : content::WebContentsObserver(web_contents) {

	11 }
	Ilya Sherman 2013/06/12 00:07:46 nit: Please move the closing curly brace to the pr nit: Please move the closing curly brace to the previous line, to match the destructor. blundell 2013/06/12 16:29:37 Done. Show quoted text On 2013/06/12 00:07:46, Ilya Sherman wrote: > nit: Please move the closing curly brace to the previous line, to match the > destructor. Done.
	12

	13 TestAutofillDriver::~TestAutofillDriver() {}

	14

	15 content::WebContents* TestAutofillDriver::GetWebContents() {

	16 return web_contents();

	17 }

	18

	19 } // namespace autofill

OLD	NEW