 Chromium Code Reviews
 Chromium Code Reviews Issue 16286018:
  Prevent excessive processing of weak maps while marking.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 16286018:
  Prevent excessive processing of weak maps while marking.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/mark-compact.h | 
| diff --git a/src/mark-compact.h b/src/mark-compact.h | 
| index 0f20440062710bbc0e9108a7e1092476ac04cdbe..4abd1e38368a332f520b24a15bb48b2abaed7e95 100644 | 
| --- a/src/mark-compact.h | 
| +++ b/src/mark-compact.h | 
| @@ -841,14 +841,18 @@ class MarkCompactCollector { | 
| // is marked. | 
| void MarkImplicitRefGroups(); | 
| - // Mark all objects which are reachable due to host application | 
| - // logic like object groups or implicit references' groups. | 
| - void ProcessExternalMarking(RootMarkingVisitor* visitor); | 
| - | 
| // Mark objects reachable (transitively) from objects in the marking stack | 
| // or overflowed in the heap. | 
| void ProcessMarkingDeque(); | 
| + // Mark objects reachable (transitively) from objects in the marking stack | 
| + // or overflowed in the heap. This respects references only considered in | 
| + // the final atomic marking pause including the following: | 
| + // - Processing of objects reachable through Harmony WeakMaps. | 
| + // - Objects reachable due to host application logic like object groups | 
| + // or implicit references' groups. | 
| + void ProcessAtomicMarking(RootMarkingVisitor* visitor); | 
| 
Hannes Payer (out of office)
2013/06/04 16:29:58
The function name may be confusing if we add concu
 
Michael Starzinger
2013/06/04 16:42:41
Yep, I am not happy with the "atomic" in the name
 
Michael Starzinger
2013/06/04 17:16:08
Done, as discussed offline.
 | 
| + | 
| // Mark objects reachable (transitively) from objects in the marking | 
| // stack. This function empties the marking stack, but may leave | 
| // overflowed objects in the heap, in which case the marking stack's |