Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/mark-compact.h

Issue 16286018: Prevent excessive processing of weak maps while marking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Hannes Payer. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 void MarkRoots(RootMarkingVisitor* visitor); 834 void MarkRoots(RootMarkingVisitor* visitor);
835 835
836 // Mark the string table specially. References to internalized strings from 836 // Mark the string table specially. References to internalized strings from
837 // the string table are weak. 837 // the string table are weak.
838 void MarkStringTable(); 838 void MarkStringTable();
839 839
840 // Mark objects in implicit references groups if their parent object 840 // Mark objects in implicit references groups if their parent object
841 // is marked. 841 // is marked.
842 void MarkImplicitRefGroups(); 842 void MarkImplicitRefGroups();
843 843
844 // Mark all objects which are reachable due to host application
845 // logic like object groups or implicit references' groups.
846 void ProcessExternalMarking(RootMarkingVisitor* visitor);
847
848 // Mark objects reachable (transitively) from objects in the marking stack 844 // Mark objects reachable (transitively) from objects in the marking stack
849 // or overflowed in the heap. 845 // or overflowed in the heap.
850 void ProcessMarkingDeque(); 846 void ProcessMarkingDeque();
851 847
848 // Mark objects reachable (transitively) from objects in the marking stack
849 // or overflowed in the heap. This respects references only considered in
850 // the final atomic marking pause including the following:
851 // - Processing of objects reachable through Harmony WeakMaps.
852 // - Objects reachable due to host application logic like object groups
853 // or implicit references' groups.
854 void ProcessEphemeralMarking(ObjectVisitor* visitor);
855
852 // Mark objects reachable (transitively) from objects in the marking 856 // Mark objects reachable (transitively) from objects in the marking
853 // stack. This function empties the marking stack, but may leave 857 // stack. This function empties the marking stack, but may leave
854 // overflowed objects in the heap, in which case the marking stack's 858 // overflowed objects in the heap, in which case the marking stack's
855 // overflow flag will be set. 859 // overflow flag will be set.
856 void EmptyMarkingDeque(); 860 void EmptyMarkingDeque();
857 861
858 // Refill the marking stack with overflowed objects from the heap. This 862 // Refill the marking stack with overflowed objects from the heap. This
859 // function either leaves the marking stack full or clears the overflow 863 // function either leaves the marking stack full or clears the overflow
860 // flag on the marking stack. 864 // flag on the marking stack.
861 void RefillMarkingDeque(); 865 void RefillMarkingDeque();
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 private: 958 private:
955 MarkCompactCollector* collector_; 959 MarkCompactCollector* collector_;
956 }; 960 };
957 961
958 962
959 const char* AllocationSpaceName(AllocationSpace space); 963 const char* AllocationSpaceName(AllocationSpace space);
960 964
961 } } // namespace v8::internal 965 } } // namespace v8::internal
962 966
963 #endif // V8_MARK_COMPACT_H_ 967 #endif // V8_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698