Issue 16286017: Revert 203950 "Remove Activity Log usage of Extension objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16286017: Revert 203950 "Remove Activity Log usage of Extension objects" (Closed)

Created:
7 years, 6 months ago by felt

Modified:
7 years, 6 months ago

Reviewers:
felt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 203950 "Remove Activity Log usage of Extension objects" > Remove Activity Log usage of Extension objects > > Previously, the AL used Extension objects when notifying the UI of new activity. If an extension were uninstalled in the middle of logging something, the Extension object would be deallocated before the UI tried to use the reference. Since we are replacing the old UI, I am switching to using IDs instead of Extension objects. > > [[[ Reverted because it was causing heapcheck failures. Retrying a new version. ]]] > > BUG=236395 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203218 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203618 > > Review URL: https://chromiumcodereview.appspot.com/15686007 TBR=felt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203967

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+264 lines, -118 lines)			Patch
M	trunk/src/chrome/browser/extensions/activity_log/activity_log.h	View	8 chunks	+29 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/activity_log/activity_log.cc	View	13 chunks	+91 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/activity_log/activity_log_unittest.cc	View	7 chunks	+67 lines, -45 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/web_request/web_request_api.cc	View	1 chunk	+22 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/event_router.cc	View	1 chunk	+19 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc	View	10 chunks	+14 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/browser/renderer_host/chrome_render_message_filter.cc	View	10 chunks	+22 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r203967.