src/sampler.cc - Issue 16286016: Notify CPU profiler when calling native getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/sampler.cc

Issue 16286016: Notify CPU profiler when calling native getters (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed check that pthread_kill always succeeds Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/sampler.cc

diff --git a/src/sampler.cc b/src/sampler.cc

index efac288ee72c0870e5d1bee9b04290e94ac7ec1f..96b20f0369fbb472a8653700760e8e30d2dafb0b 100644

--- a/src/sampler.cc

+++ b/src/sampler.cc

@@ -496,9 +496,7 @@ class SamplerThread : public Thread {

void SampleContext(Sampler* sampler) {

if (!SignalHandler::Installed()) return;

pthread_t tid = sampler->platform_data()->vm_tid();

- int result = pthread_kill(tid, SIGPROF);

- USE(result);

- ASSERT(result == 0);

+ pthread_kill(tid, SIGPROF);

}

#elif defined(__MACH__)

« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »