Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 16286003: Increase omnibox size by 2 px. Increase nominal font size in omnibox to 16 px. (Closed)

Created:
7 years, 6 months ago by Peter Kasting
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su, oshima+watch_chromium.org
Visibility:
Public.

Description

Increase omnibox size by 2 px. Increase nominal font size in omnibox to 16 px. The old omnibox background asset was semitransparent (for CrOS) and had to be drawn-over with the appropriate background color. The new assets split the border (used by everyone) from the filling (used by CrOS alone). As a result, when the filling is not in use, we can now draw the background behind the omnibox instead of in front, resulting in better antialiasing. (Sadly, we still need to draw a shape that fits "inside" the borders since the borders are also semitransparent and have to overlay the toolbar in some places and the omnibox background in others; this is unavoidable unless we want to change to a fixed- color or programmatically-drawn omnibox border.) All PNGs were compressed with build/sanitize-png-files.sh -o2. BUG=231005 TEST=Omnibox is 2 px larger, contents still look OK R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -94 lines) Patch
M chrome/app/theme/theme_resources.grd View 2 chunks +44 lines, -2 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 5 chunks +39 lines, -52 lines 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
Unfortunately, gclient crashes when I try to upload a change with certain PNGs in it ...
7 years, 6 months ago (2013-06-01 00:21:09 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-01 15:54:57 UTC) #2
Peter Kasting
7 years, 6 months ago (2013-06-04 01:49:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r203814.

Powered by Google App Engine
This is Rietveld 408576698