Chromium Code Reviews Chromium Code Reviews
Issue 16285002:
Do not invoke or clear hover effects on node deletion when cursor is invisible (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <html> | |
| 3 <head> | |
| 4 <style> | |
| 5 #red { | |
| 6 background-color: red; | |
| 7 position: absolute; | |
| 8 left: 50px; | |
| 9 top: 50px; | |
| 10 height: 100px; | |
| 11 width: 100px; | |
| 12 } | |
| 13 | |
| 14 #blue { | |
| 15 background-color: blue; | |
| 16 position: absolute; | |
| 17 left: 50px; | |
| 18 top: 200px; | |
| 19 height: 100px; | |
| 20 width: 100px; | |
| 21 } | |
| 22 #blue:hover::after { | |
| 23 content: " Hovered."; | |
| 24 } | |
| 25 | |
| 26 </style> | |
| 27 <script src="../js/resources/js-test-pre.js"></script> | |
| 28 </head> | |
| 29 <body onload="runtest()" style="margin:0"> | |
| 30 | |
| 31 <script type="text/javascript"> | |
| 32 var redDiv; | |
| 33 var blueDiv; | |
| 34 var startTime; | |
| 35 var blueTextWhenHovered = "Blue. Hovered."; | |
| 36 var redTextWhenHovered = "Red. Hovered. Keydown to delete." | |
| 37 var blueTextWhenNotHovered = "Blue."; | |
| 38 function runtest() | |
| 39 { | |
| 40 if (!window.testRunner || !window.eventSender) | |
| 41 return; | |
| 42 | |
| 43 if (!window.internals || !window.internals.setIsCursorVisible) { | |
| 44 debug("window.internals.setIsCursorVisible is required to run this test. "); | |
| 45 return; | |
| 46 } | |
| 47 | |
| 48 testRunner.waitUntilDone(); | |
| 49 | |
| 50 redDiv = document.getElementById('red'); | |
| 51 blueDiv = document.getElementById('blue'); | |
| 52 | |
| 53 redDiv.addEventListener('mouseover', function(e) { | |
| 54 this.innerHTML = redTextWhenHovered; | |
| 55 }); | |
| 56 | |
| 57 document.addEventListener('keydown', function(e) { | |
| 58 blueDiv.style.top = "50px"; | |
| 59 redDiv.parentNode.removeChild(redDiv); | |
| 60 }); | |
| 61 | |
| 62 debug("Mouse is visible, moving it over the red div."); | |
| 63 internals.setIsCursorVisible(document, true); | |
| 64 eventSender.mouseMoveTo(100, 100); | |
| 65 shouldBeEqualToString("redDiv.innerHTML", redTextWhenHovered); | |
| 66 shouldBeEqualToString("blueDiv.innerHTML", blueTextWhenNotHovered); | |
| 67 | |
| 68 debug("Setting the mouse cursor to be invisible."); | |
| 69 internals.setIsCursorVisible(document, false); | |
| 70 shouldBeEqualToString("redDiv.innerHTML", redTextWhenHovered); | |
| 71 shouldBeEqualToString("blueDiv.innerHTML", blueTextWhenNotHovered); | |
| 72 | |
| 73 debug("Mouse is invisible, deleting the red div."); | |
| 74 eventSender.keyDown("a"); | |
| 75 window.setTimeout(testAfterDelete, 0); | |
| 76 } | |
| 77 | |
| 78 function testAfterDelete() | |
| 79 { | |
| 80 shouldBe("blueDiv.offsetTop", "50"); | |
| 81 shouldBe(window.getComputedStyle(document.querySelector('#blue'), ':after'). content, ""); | |
|
Rick Byers
2013/06/03 23:00:17
This is good, but to reduce brittleness it would b
Rick Byers
2013/06/03 23:00:17
Put the expression (or part of the expression) ins
tdanderson
2013/06/04 22:17:41
Done.
tdanderson
2013/06/04 22:17:41
Done. As is, this could do with a bit more refacto
| |
| 82 testRunner.notifyDone(); | |
| 83 } | |
| 84 | |
| 85 </script> | |
| 86 | |
| 87 <div id="red">Red.</div> | |
| 88 <div id="blue">Blue.</div> | |
| 89 | |
| 90 <p>Test for <a href="http://crbug.com/240722">http://crbug.com/240722</a>. If th e mouse cursor is not visible, no new hover effects should be invoked when the c urrently hovered node is removed from the DOM.</p> | |
| 91 | |
| 92 <div id="console"></div> | |
| 93 </body> | |
| 94 </html> | |
| OLD | NEW |
