Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 16285002: Do not invoke or clear hover effects on node deletion when cursor is invisible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/hover-after-dom-delete-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3096 matching lines...) Expand 10 before | Expand all | Expand 10 after
3107 } 3107 }
3108 3108
3109 void Document::hoveredNodeDetached(Node* node) 3109 void Document::hoveredNodeDetached(Node* node)
3110 { 3110 {
3111 if (!m_hoverNode || (node != m_hoverNode && (!m_hoverNode->isTextNode() || n ode != m_hoverNode->parentNode()))) 3111 if (!m_hoverNode || (node != m_hoverNode && (!m_hoverNode->isTextNode() || n ode != m_hoverNode->parentNode())))
3112 return; 3112 return;
3113 3113
3114 m_hoverNode = node->parentNode(); 3114 m_hoverNode = node->parentNode();
3115 while (m_hoverNode && !m_hoverNode->renderer()) 3115 while (m_hoverNode && !m_hoverNode->renderer())
3116 m_hoverNode = m_hoverNode->parentNode(); 3116 m_hoverNode = m_hoverNode->parentNode();
3117
3118 // If the mouse cursor is not visible, do not clear existing
3119 // hover effects on the ancestors of |node| and do not invoke
3120 // new hover effects on any other element.
3121 if (!page()->isCursorVisible())
3122 return;
3123
3117 if (frame()) 3124 if (frame())
3118 frame()->eventHandler()->scheduleHoverStateUpdate(); 3125 frame()->eventHandler()->scheduleHoverStateUpdate();
3119 } 3126 }
3120 3127
3121 void Document::activeChainNodeDetached(Node* node) 3128 void Document::activeChainNodeDetached(Node* node)
3122 { 3129 {
3123 if (!m_activeElement || (node != m_activeElement && (!m_activeElement->isTex tNode() || node != m_activeElement->parentNode()))) 3130 if (!m_activeElement || (node != m_activeElement && (!m_activeElement->isTex tNode() || node != m_activeElement->parentNode())))
3124 return; 3131 return;
3125 3132
3126 m_activeElement = node->parentElement(); 3133 m_activeElement = node->parentElement();
(...skipping 2487 matching lines...) Expand 10 before | Expand all | Expand 10 after
5614 return; 5621 return;
5615 5622
5616 Vector<RefPtr<Element> > associatedFormControls; 5623 Vector<RefPtr<Element> > associatedFormControls;
5617 copyToVector(m_associatedFormControls, associatedFormControls); 5624 copyToVector(m_associatedFormControls, associatedFormControls);
5618 5625
5619 frame()->page()->chrome().client()->didAssociateFormControls(associatedFormC ontrols); 5626 frame()->page()->chrome().client()->didAssociateFormControls(associatedFormC ontrols);
5620 m_associatedFormControls.clear(); 5627 m_associatedFormControls.clear();
5621 } 5628 }
5622 5629
5623 } // namespace WebCore 5630 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/hover-after-dom-delete-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698