Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1628443003: Use GN to copy crt objects into fusl sysroot (Closed)

Created:
4 years, 11 months ago by Petr Hosek
Modified:
4 years, 11 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@gn-update
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use GN to copy crt objects into fusl sysroot We can avoid using the external script and copy the crt files directly using GN and Ninja. BUG=#619 R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a97594e85133a49f61d17195c8fc2d2fb2e92be4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -97 lines) Patch
M fusl/BUILD.gn View 2 chunks +50 lines, -38 lines 0 comments Download
D fusl/tools/copy_crt.py View 1 chunk +0 lines, -59 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
Petr Hosek
4 years, 11 months ago (2016-01-23 01:32:49 UTC) #3
kulakowski
lgtm
4 years, 11 months ago (2016-01-25 19:18:37 UTC) #5
Petr Hosek
4 years, 11 months ago (2016-01-25 22:23:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a97594e85133a49f61d17195c8fc2d2fb2e92be4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698