Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 1628423002: Add frameId to chrome.tabs.executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissiondata-remove-process_id
Patch Set: Nits + comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
index 93097caf320dc0a984ef6f6d6b5d5f425c7b151a..e429dba1249a17a4dc917e7de647bde113d237b1 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
@@ -67,6 +67,7 @@
#include "content/public/browser/web_ui.h"
#include "content/public/common/content_switches.h"
#include "extensions/browser/event_router.h"
+#include "extensions/browser/extension_api_frame_id_map.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/file_reader.h"
@@ -127,20 +128,21 @@ void ExecuteScriptHelper(
return;
if (!extensions::TabHelper::FromWebContents(web_contents))
extensions::TabHelper::CreateForWebContents(web_contents);
- extensions::TabHelper::FromWebContents(web_contents)->script_executor()->
- ExecuteScript(HostID(HostID::EXTENSIONS, extension_id),
- extensions::ScriptExecutor::JAVASCRIPT,
- code,
- extensions::ScriptExecutor::ALL_FRAMES,
- extensions::ScriptExecutor::DONT_MATCH_ABOUT_BLANK,
- extensions::UserScript::DOCUMENT_IDLE,
- extensions::ScriptExecutor::ISOLATED_WORLD,
- extensions::ScriptExecutor::DEFAULT_PROCESS,
- GURL(), // No webview src.
- GURL(), // No file url.
- false, // Not user gesture.
- extensions::ScriptExecutor::NO_RESULT,
- extensions::ScriptExecutor::ExecuteScriptCallback());
+ extensions::TabHelper::FromWebContents(web_contents)
+ ->script_executor()
+ ->ExecuteScript(HostID(HostID::EXTENSIONS, extension_id),
+ extensions::ScriptExecutor::JAVASCRIPT, code,
+ extensions::ScriptExecutor::ALL_FRAMES,
+ extensions::ExtensionApiFrameIdMap::kTopFrameId,
+ extensions::ScriptExecutor::DONT_MATCH_ABOUT_BLANK,
+ extensions::UserScript::DOCUMENT_IDLE,
+ extensions::ScriptExecutor::ISOLATED_WORLD,
+ extensions::ScriptExecutor::DEFAULT_PROCESS,
+ GURL(), // No webview src.
+ GURL(), // No file url.
+ false, // Not user gesture.
+ extensions::ScriptExecutor::NO_RESULT,
+ extensions::ScriptExecutor::ExecuteScriptCallback());
}
// Helper class that directly loads an extension's content scripts into

Powered by Google App Engine
This is Rietveld 408576698