Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: extensions/browser/script_executor.h

Issue 1628423002: Add frameId to chrome.tabs.executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissiondata-remove-process_id
Patch Set: Revert to wc->GetURL for chrome.tabs.update Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/script_executor.h
diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h
index 4f81b78fb62dfe17964aa2600e57b5cbf0c4c6fe..0164003c4e87cfd51813c89e8213617957df6344 100644
--- a/extensions/browser/script_executor.h
+++ b/extensions/browser/script_executor.h
@@ -44,7 +44,7 @@ class ScriptExecutor {
// The scope of the script injection across the frames.
enum FrameScope {
- TOP_FRAME,
+ SINGLE_FRAME,
ALL_FRAMES,
};
@@ -89,6 +89,7 @@ class ScriptExecutor {
ScriptType script_type,
const std::string& code,
FrameScope frame_scope,
+ int frame_id,
Devlin 2016/01/25 19:36:40 Man, this function makes me so sad. At the same t
robwu 2016/01/26 11:03:02 Done.
MatchAboutBlank match_about_blank,
UserScript::RunLocation run_at,
WorldType world_type,

Powered by Google App Engine
This is Rietveld 408576698