chrome/test/data/extensions/api_test/executescript/navigation_race/test.js - Issue 1628423002: Add frameId to chrome.tabs.executeScript/insertCSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/executescript/navigation_race/test.js

Issue 1628423002: Add frameId to chrome.tabs.executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissiondata-remove-process_id

Patch Set: Remove unused include from rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/executescript/frame_id/test.js ('k') | extensions/browser/api/execute_code_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/executescript/navigation_race/test.js

diff --git a/chrome/test/data/extensions/api_test/executescript/navigation_race/test.js b/chrome/test/data/extensions/api_test/executescript/navigation_race/test.js

index 02bd14b9d9d0ab7bc296a6e8916026037124c284..fb4f7e0166bdccbad7ae3da6f47b1c021a195d20 100644

--- a/chrome/test/data/extensions/api_test/executescript/navigation_race/test.js

+++ b/chrome/test/data/extensions/api_test/executescript/navigation_race/test.js

@@ -17,9 +17,10 @@ chrome.test.getConfig(function(config) {

// the script, so it's still showing a.com, where we don't have

// permission to run it.

if (chrome.runtime.lastError) {

- chrome.test.assertTrue(

- chrome.runtime.lastError.message.indexOf(

- 'Cannot access contents of the page.') == 0);

+ chrome.test.assertLastError(

+ 'Cannot access contents of url "' + urlA +

+ '". Extension manifest must request permission to access this ' +

+ 'host.');

chrome.test.notifyPass();

} else {

// If there were no errors, then the script did run, but it should