Add frameId to chrome.tabs.executeScript/insertCSS

extensions/browser/script_executor.h

Index: extensions/browser/script_executor.h
diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h
index 4f81b78fb62dfe17964aa2600e57b5cbf0c4c6fe..6f7cd8dd0d5490e6bae6dceced5a3ce21a98c84c 100644
--- a/extensions/browser/script_executor.h
+++ b/extensions/browser/script_executor.h
@@ -44,8 +44,8 @@ class ScriptExecutor {
 
   // The scope of the script injection across the frames.
   enum FrameScope {
-    TOP_FRAME,
-    ALL_FRAMES,
+    SINGLE_FRAME,
+    INCLUDE_SUB_FRAMES,
   };
 
   // Whether to insert the script in about: frames when its origin matches
@@ -82,6 +82,10 @@ class ScriptExecutor {
   // Executes a script. The arguments match ExtensionMsg_ExecuteCode_Params in
   // extension_messages.h (request_id is populated automatically).
   //
+  // The script will be executed in the frame identified by |frame_id| (which is
+  // an extension API frame ID). If |frame_scope| is ALL_FRAMES, then the script

[Devlin, 2016/02/01 19:04:07]

nit: s/ALL_FRAMES/INCLUDE_SUB_FRAMES

[robwu, 2016/02/02 15:28:19]

Done.

+  // will also be executed in all descendants of the frame.
+  //
   // |callback| will always be called even if the IPC'd renderer is destroyed
   // before a response is received (in this case the callback will be with a
   // failure and appropriate error message).
@@ -89,6 +93,7 @@ class ScriptExecutor {
                      ScriptType script_type,
                      const std::string& code,
                      FrameScope frame_scope,
+                     int frame_id,
                      MatchAboutBlank match_about_blank,
                      UserScript::RunLocation run_at,
                      WorldType world_type,