Issue 1628413002: asdfsdf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1628413002: asdfsdf

Created:
4 years, 11 months ago by zino

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, ajuma+watch-canvas_chromium.org, Rik, Justin Novosad, dshwang

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

asdfsdf Canvas2d: addHitRegion() should take clipping region into account. Current implementation ignores the clipping region when calling addHitRegion(). In the past, we had no way to get the current clip path from canvas state stack in Blink side but it's been possible since display list 2d canvas feature. BUG=387057

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -5 lines)			Patch
A	third_party/WebKit/LayoutTests/fast/canvas/canvas-hit-regions-clip-test.html	View	1 chunk	+67 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/canvas2d/ClipList.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/canvas2d/ClipList.cpp	View	2 chunks	+10 lines, -0 lines	0 comments	Download