Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1628363002: Build and link microhttpd from gyp (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -14 lines) Patch
A gyp/microhttpd.gyp View 1 1 chunk +43 lines, -0 lines 0 comments Download
M gyp/skiaserve.gyp View 1 2 chunks +1 line, -14 lines 0 comments Download
A third_party/libmicrohttpd/build.py View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
joshualitt
I'm not totally sure who to add for the gyp file, if you know of ...
4 years, 11 months ago (2016-01-25 15:29:54 UTC) #3
ethannicholas
On 2016/01/25 15:29:54, joshualitt wrote: > I'm not totally sure who to add for the ...
4 years, 11 months ago (2016-01-25 15:34:25 UTC) #4
jcgregorio
LGTM for the Python. No idea about the gyp.
4 years, 11 months ago (2016-01-25 18:20:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1628363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1628363002/40001
4 years, 11 months ago (2016-01-25 18:35:08 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 18:50:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8cc3f4e38ff241547a2e1f2a4160491dc8579e7c

Powered by Google App Engine
This is Rietveld 408576698