Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 1628283002: posinset and setsize for input type, radio, exposed in AX tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 AXObject* popupRootAXObject(); 260 AXObject* popupRootAXObject();
261 void didNotifySubtreeInsertionsToDocument() override; 261 void didNotifySubtreeInsertionsToDocument() override;
262 262
263 virtual void ensureFallbackContent(); 263 virtual void ensureFallbackContent();
264 virtual void ensurePrimaryContent(); 264 virtual void ensurePrimaryContent();
265 bool hasFallbackContent() const; 265 bool hasFallbackContent() const;
266 266
267 bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; } 267 bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; }
268 void setPlaceholderVisibility(bool) override; 268 void setPlaceholderVisibility(bool) override;
269 269
270 void needUpdatePositionOfRadioGroup() const;
271 void setPositionInRadioGroup(unsigned position) { m_positonInRadio = positio n; }
272 unsigned positionInRadioGroup() const;
273 unsigned sizeOfRadioGroup() const;
274
270 protected: 275 protected:
271 HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser); 276 HTMLInputElement(Document&, HTMLFormElement*, bool createdByParser);
272 277
273 void defaultEventHandler(Event*) override; 278 void defaultEventHandler(Event*) override;
274 279
275 private: 280 private:
276 enum AutoCompleteSetting { Uninitialized, On, Off }; 281 enum AutoCompleteSetting { Uninitialized, On, Off };
277 282
278 void didAddUserAgentShadowRoot(ShadowRoot&) final; 283 void didAddUserAgentShadowRoot(ShadowRoot&) final;
279 void willAddFirstAuthorShadowRoot() final; 284 void willAddFirstAuthorShadowRoot() final;
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 PassRefPtr<ComputedStyle> customStyleForLayoutObject() override; 375 PassRefPtr<ComputedStyle> customStyleForLayoutObject() override;
371 376
372 bool shouldDispatchFormControlChangeEvent(String&, String&) override; 377 bool shouldDispatchFormControlChangeEvent(String&, String&) override;
373 378
374 AtomicString m_name; 379 AtomicString m_name;
375 String m_valueIfDirty; 380 String m_valueIfDirty;
376 String m_suggestedValue; 381 String m_suggestedValue;
377 int m_size; 382 int m_size;
378 int m_maxLength; 383 int m_maxLength;
379 int m_minLength; 384 int m_minLength;
385 unsigned m_positonInRadio;
keishi 2016/02/16 02:22:46 I think its ok to have code/API to support accedss
je_julie(Not used) 2016/02/16 05:19:03 Right. It'd better adding new AXRadioButton class
380 short m_maxResults; 386 short m_maxResults;
381 unsigned m_isChecked : 1; 387 unsigned m_isChecked : 1;
382 unsigned m_reflectsCheckedAttribute : 1; 388 unsigned m_reflectsCheckedAttribute : 1;
383 unsigned m_isIndeterminate : 1; 389 unsigned m_isIndeterminate : 1;
384 unsigned m_isActivatedSubmit : 1; 390 unsigned m_isActivatedSubmit : 1;
385 unsigned m_autocomplete : 2; // AutoCompleteSetting 391 unsigned m_autocomplete : 2; // AutoCompleteSetting
386 unsigned m_hasNonEmptyList : 1; 392 unsigned m_hasNonEmptyList : 1;
387 unsigned m_stateRestored : 1; 393 unsigned m_stateRestored : 1;
388 unsigned m_parsingInProgress : 1; 394 unsigned m_parsingInProgress : 1;
389 unsigned m_valueAttributeWasUpdatedAfterParsing : 1; 395 unsigned m_valueAttributeWasUpdatedAfterParsing : 1;
390 unsigned m_canReceiveDroppedFiles : 1; 396 unsigned m_canReceiveDroppedFiles : 1;
391 unsigned m_hasTouchEventHandler : 1; 397 unsigned m_hasTouchEventHandler : 1;
392 unsigned m_shouldRevealPassword : 1; 398 unsigned m_shouldRevealPassword : 1;
393 unsigned m_needsToUpdateViewValue : 1; 399 unsigned m_needsToUpdateViewValue : 1;
394 unsigned m_isPlaceholderVisible : 1; 400 unsigned m_isPlaceholderVisible : 1;
395 RefPtrWillBeMember<InputType> m_inputType; 401 RefPtrWillBeMember<InputType> m_inputType;
396 RefPtrWillBeMember<InputTypeView> m_inputTypeView; 402 RefPtrWillBeMember<InputTypeView> m_inputTypeView;
397 // The ImageLoader must be owned by this element because the loader code ass umes 403 // The ImageLoader must be owned by this element because the loader code ass umes
398 // that it lives as long as its owning element lives. If we move the loader into 404 // that it lives as long as its owning element lives. If we move the loader into
399 // the ImageInput object we may delete the loader while this element lives o n. 405 // the ImageInput object we may delete the loader while this element lives o n.
400 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader; 406 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
401 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r; 407 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r;
402 }; 408 };
403 409
404 } // namespace blink 410 } // namespace blink
405 411
406 #endif // HTMLInputElement_h 412 #endif // HTMLInputElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698