Introduce PPB_UDPSocket_Dev.

ppapi/proxy/udp_socket_private_resource.cc

Index: ppapi/proxy/udp_socket_private_resource.cc
diff --git a/ppapi/proxy/udp_socket_private_resource.cc b/ppapi/proxy/udp_socket_private_resource.cc
index 608fc00a1613d5bd59e3bbd30ba97c45886f9997..cd2333c9df9b79930a8035d34525bdb4bb914e1c 100644
--- a/ppapi/proxy/udp_socket_private_resource.cc
+++ b/ppapi/proxy/udp_socket_private_resource.cc
@@ -4,37 +4,14 @@
 
 #include "ppapi/proxy/udp_socket_private_resource.h"
 
-#include <algorithm>
-#include <cstring>
-
-#include "base/basictypes.h"
-#include "base/logging.h"
-#include "ppapi/c/pp_bool.h"
-#include "ppapi/c/pp_completion_callback.h"
-#include "ppapi/c/pp_errors.h"
-#include "ppapi/proxy/ppapi_messages.h"
+#include "ppapi/shared_impl/tracked_callback.h"
 
 namespace ppapi {
 namespace proxy {
 
-const int32_t UDPSocketPrivateResource::kMaxReadSize = 1024 * 1024;
-const int32_t UDPSocketPrivateResource::kMaxWriteSize = 1024 * 1024;
-
 UDPSocketPrivateResource::UDPSocketPrivateResource(Connection connection,
                                                    PP_Instance instance)
-    : PluginResource(connection, instance),
-      bound_(false),
-      closed_(false),
-      read_buffer_(NULL),
-      bytes_to_read_(-1) {
-  recvfrom_addr_.size = 0;
-  memset(recvfrom_addr_.data, 0,
-         arraysize(recvfrom_addr_.data) * sizeof(*recvfrom_addr_.data));
-  bound_addr_.size = 0;
-  memset(bound_addr_.data, 0,
-         arraysize(bound_addr_.data) * sizeof(*bound_addr_.data));
-
-  SendCreate(BROWSER, PpapiHostMsg_UDPSocketPrivate_Create());
+    : UDPSocketResourceBase(connection, instance) {
 }
 
 UDPSocketPrivateResource::~UDPSocketPrivateResource() {
@@ -48,80 +25,29 @@ UDPSocketPrivateResource::AsPPB_UDPSocket_Private_API() {
 int32_t UDPSocketPrivateResource::SetSocketFeature(
     PP_UDPSocketFeature_Private name,
     PP_Var value) {
-  if (bound_ || closed_)
-    return PP_ERROR_FAILED;
-
-  switch (name) {
-    case PP_UDPSOCKETFEATURE_ADDRESS_REUSE:
-    case PP_UDPSOCKETFEATURE_BROADCAST:
-      if (value.type != PP_VARTYPE_BOOL)
-        return PP_ERROR_BADARGUMENT;
-      SendBoolSocketFeature(static_cast<int32_t>(name),
-                            PP_ToBool(value.value.as_bool));
-      break;
-    default:
-      return PP_ERROR_BADARGUMENT;
-  }
-  return PP_OK;
+  return SetSocketFeatureImpl(name, value);
 }
 
 int32_t UDPSocketPrivateResource::Bind(
     const PP_NetAddress_Private* addr,
     scoped_refptr<TrackedCallback> callback) {
-  if (!addr)
-    return PP_ERROR_BADARGUMENT;
-  if (bound_ || closed_)
-    return PP_ERROR_FAILED;
-  if (TrackedCallback::IsPending(bind_callback_))
-    return PP_ERROR_INPROGRESS;
-
-  bind_callback_ = callback;
-
-  // Send the request, the browser will call us back via BindReply.
-  SendBind(*addr);
-  return PP_OK_COMPLETIONPENDING;
+  return BindImpl(addr, callback);
 }
 
 PP_Bool UDPSocketPrivateResource::GetBoundAddress(PP_NetAddress_Private* addr) {
-  if (!addr || !bound_ || closed_)
-    return PP_FALSE;
-
-  *addr = bound_addr_;
-  return PP_TRUE;
+  return GetBoundAddressImpl(addr);
 }
 
 int32_t UDPSocketPrivateResource::RecvFrom(
     char* buffer,
     int32_t num_bytes,
     scoped_refptr<TrackedCallback> callback) {
-  if (!buffer || num_bytes <= 0)
-    return PP_ERROR_BADARGUMENT;
-  if (!bound_)
-    return PP_ERROR_FAILED;
-  if (TrackedCallback::IsPending(recvfrom_callback_))
-    return PP_ERROR_INPROGRESS;
-
-  read_buffer_ = buffer;
-  bytes_to_read_ = std::min(num_bytes, kMaxReadSize);
-  recvfrom_callback_ = callback;
-
-  // Send the request, the browser will call us back via RecvFromReply.
-  SendRecvFrom(bytes_to_read_);
-  return PP_OK_COMPLETIONPENDING;
+  return RecvFromImpl(buffer, num_bytes, NULL, callback);
 }
 
 PP_Bool UDPSocketPrivateResource::GetRecvFromAddress(
     PP_NetAddress_Private* addr) {
-  if (!addr)
-    return PP_FALSE;
-  *addr = recvfrom_addr_;
-  return PP_TRUE;
-}
-
-void UDPSocketPrivateResource::PostAbortIfNecessary(
-    scoped_refptr<TrackedCallback>* callback) {
-  if (TrackedCallback::IsPending(*callback))
-    (*callback)->PostAbort();
+  return GetRecvFromAddressImpl(addr);
 }
 
 int32_t UDPSocketPrivateResource::SendTo(
@@ -129,123 +55,11 @@ int32_t UDPSocketPrivateResource::SendTo(
     int32_t num_bytes,
     const PP_NetAddress_Private* addr,
     scoped_refptr<TrackedCallback> callback) {
-  if (!buffer || num_bytes <= 0 || !addr)
-    return PP_ERROR_BADARGUMENT;
-  if (!bound_)
-    return PP_ERROR_FAILED;
-  if (TrackedCallback::IsPending(sendto_callback_))
-    return PP_ERROR_INPROGRESS;
-
-  if (num_bytes > kMaxWriteSize)
-    num_bytes = kMaxWriteSize;
-
-  sendto_callback_ = callback;
-
-  // Send the request, the browser will call us back via SendToReply.
-  SendSendTo(std::string(buffer, num_bytes), *addr);
-  return PP_OK_COMPLETIONPENDING;
+  return SendToImpl(buffer, num_bytes, addr, callback);
 }
 
 void UDPSocketPrivateResource::Close() {
-  if(closed_)
-    return;
-
-  bound_ = false;
-  closed_ = true;
-
-  SendClose();
-
-  PostAbortIfNecessary(&bind_callback_);
-  PostAbortIfNecessary(&recvfrom_callback_);
-  PostAbortIfNecessary(&sendto_callback_);
-}
-
-void UDPSocketPrivateResource::SendBoolSocketFeature(int32_t name, bool value) {
-  PpapiHostMsg_UDPSocketPrivate_SetBoolSocketFeature msg(name, value);
-  Post(BROWSER, msg);
-}
-
-void UDPSocketPrivateResource::SendBind(const PP_NetAddress_Private& addr) {
-  PpapiHostMsg_UDPSocketPrivate_Bind msg(addr);
-  Call<PpapiPluginMsg_UDPSocketPrivate_BindReply>(
-      BROWSER,
-      msg,
-      base::Bind(&UDPSocketPrivateResource::OnPluginMsgBindReply,
-                 base::Unretained(this)));
-}
-
-void UDPSocketPrivateResource::SendRecvFrom(int32_t num_bytes) {
-  PpapiHostMsg_UDPSocketPrivate_RecvFrom msg(num_bytes);
-  Call<PpapiPluginMsg_UDPSocketPrivate_RecvFromReply>(
-      BROWSER,
-      msg,
-      base::Bind(&UDPSocketPrivateResource::OnPluginMsgRecvFromReply,
-                 base::Unretained(this)));
-}
-
-void UDPSocketPrivateResource::SendSendTo(const std::string& buffer,
-                                          const PP_NetAddress_Private& addr) {
-  PpapiHostMsg_UDPSocketPrivate_SendTo msg(buffer, addr);
-  Call<PpapiPluginMsg_UDPSocketPrivate_SendToReply>(
-      BROWSER,
-      msg,
-      base::Bind(&UDPSocketPrivateResource::OnPluginMsgSendToReply,
-                 base::Unretained(this)));
-}
-
-void UDPSocketPrivateResource::SendClose() {
-  PpapiHostMsg_UDPSocketPrivate_Close msg;
-  Post(BROWSER, msg);
-}
-
-void UDPSocketPrivateResource::OnPluginMsgBindReply(
-    const ResourceMessageReplyParams& params,
-    const PP_NetAddress_Private& bound_addr) {
-  if (!TrackedCallback::IsPending(bind_callback_)) {
-    NOTREACHED();
-    return;
-  }
-  if (params.result() == PP_OK)
-    bound_ = true;
-  bound_addr_ = bound_addr;
-  bind_callback_->Run(params.result());
-}
-
-void UDPSocketPrivateResource::OnPluginMsgRecvFromReply(
-    const ResourceMessageReplyParams& params,
-    const std::string& data,
-    const PP_NetAddress_Private& addr) {
-  if (!TrackedCallback::IsPending(recvfrom_callback_) || !read_buffer_) {
-    NOTREACHED();
-    return;
-  }
-  bool succeeded = (params.result() == PP_OK);
-  if (succeeded) {
-    CHECK_LE(static_cast<int32_t>(data.size()), bytes_to_read_);
-    if (!data.empty())
-      memcpy(read_buffer_, data.c_str(), data.size());
-  }
-  read_buffer_ = NULL;
-  bytes_to_read_ = -1;
-  recvfrom_addr_ = addr;
-
-  if (succeeded)
-    recvfrom_callback_->Run(static_cast<int32_t>(data.size()));
-  else
-    recvfrom_callback_->Run(params.result());
-}
-
-void UDPSocketPrivateResource::OnPluginMsgSendToReply(
-    const ResourceMessageReplyParams& params,
-    int32_t bytes_written) {
-  if (!TrackedCallback::IsPending(sendto_callback_)) {
-    NOTREACHED();
-    return;
-  }
-  if (params.result() == PP_OK)
-    sendto_callback_->Run(bytes_written);
-  else
-    sendto_callback_->Run(params.result());
+  CloseImpl();
 }
 
 }  // namespace proxy