Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 1628173002: Don't NULL-check GlobalHandle::Node::object_ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/global-handles.cc ('K') | « src/global-handles.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 v8::Local<v8::Object> o = v8::Object::New(isolate); 394 v8::Local<v8::Object> o = v8::Object::New(isolate);
395 CHECK(!o.IsEmpty()); 395 CHECK(!o.IsEmpty());
396 v8::Persistent<v8::Object> p(isolate, o); 396 v8::Persistent<v8::Object> p(isolate, o);
397 CHECK(o == p.Get(isolate)); 397 CHECK(o == p.Get(isolate));
398 CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate)); 398 CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate));
399 399
400 v8::Global<v8::Object> g(isolate, o); 400 v8::Global<v8::Object> g(isolate, o);
401 CHECK(o == g.Get(isolate)); 401 CHECK(o == g.Get(isolate));
402 CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate)); 402 CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate));
403 } 403 }
404
405
406 void WeakCallback(const v8::WeakCallbackInfo<void>& data) {}
407
408
409 TEST(WeakPersistentSmi) {
410 CcTest::InitializeVM();
411 v8::Isolate* isolate = CcTest::isolate();
412
413 v8::HandleScope scope(isolate);
414 v8::Local<v8::Number> n = v8::Number::New(isolate, 0);
415 v8::Global<v8::Number> g(isolate, n);
416
417 // Should not crash.
418 g.SetWeak<void>(nullptr, &WeakCallback, v8::WeakCallbackType::kParameter);
419 }
OLDNEW
« src/global-handles.cc ('K') | « src/global-handles.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698