Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 162813004: [OSX, rAC] Fix helpers to match Views behavior. (Closed)

Created:
6 years, 10 months ago by groby-ooo-7-16
Modified:
6 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[OSX, rAC] Fix helpers to match Views behavior. The field accessor functions for the Views test helpers only obtain values from sections that are actually active. (By virtue of the way the Views dialog is built). Match OSX to do the same. NOTRY=true BUG=none R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
chrome/browser/ui/cocoa/autofill/autofill_dialog_view_tester_cocoa.mm View 3 chunks +6 lines, -0 lines 0 comments Download
chrome/browser/ui/cocoa/autofill/autofill_section_container.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
6 years, 10 months ago (2014-02-13 21:25:05 UTC) #1
Evan Stade
lgtm can you submit this now before the other CL is submitted, i.e. will it ...
6 years, 10 months ago (2014-02-13 23:11:50 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-13 23:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/162813004/1
6 years, 10 months ago (2014-02-13 23:37:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 03:36:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201930
6 years, 10 months ago (2014-02-14 03:36:57 UTC) #6
groby-ooo-7-16
Set NOTRY=true since CQ is borked and dcommit can't connect to svn.chromium.org - FML
6 years, 10 months ago (2014-02-14 03:42:21 UTC) #7
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-14 03:42:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/162813004/1
6 years, 10 months ago (2014-02-14 03:44:43 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 03:47:42 UTC) #10
Message was sent while issue was closed.
Change committed as 251245

Powered by Google App Engine
This is Rietveld 408576698