Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162813003: Restore ShellWindow app icon in RegisterApp (Closed)

Created:
6 years, 10 months ago by stevenjb
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Restore ShellWindow app icon in RegisterApp BUG=338972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
You had the right idea, but we need to set image_set_by_controller_. Also, we already hang ...
6 years, 10 months ago (2014-02-13 19:04:20 UTC) #1
Mr4D (OOO till 08-26)
lgtm Great! Many thanks for looking into this! (I had the feeling that there must ...
6 years, 10 months ago (2014-02-13 19:12:43 UTC) #2
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 10 months ago (2014-02-13 19:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/162813003/1
6 years, 10 months ago (2014-02-13 20:13:19 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 22:59:31 UTC) #5
Message was sent while issue was closed. 
Change committed as 251173

Powered by Google App Engine
This is Rietveld 408576698