Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1628013003: Update webkit test expectations for sloppy functions in case (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update webkit test expectations for sloppy functions in case A recent ES2015 semantics web compatibility fix changed a WebKit test from a syntax error to a known failure without a syntax error. This confused the fuzzer infrastructure. This patch updates the test expectations to the expected output, based on what the new semantics provide. R=machenbach,adamk BUG=v8:4693 LOG=N Committed: https://crrev.com/5ef27c25e9cbc9d78abd580c3c8b7f121db69fc5 Cr-Commit-Position: refs/heads/master@{#33484}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M test/webkit/function-declarations-in-switch-statement-expected.txt View 1 chunk +1 line, -1 line 2 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dan Ehrenberg
4 years, 11 months ago (2016-01-25 08:45:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1628013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1628013003/1
4 years, 11 months ago (2016-01-25 08:45:55 UTC) #3
Michael Achenbach
lgtm https://codereview.chromium.org/1628013003/diff/1/test/webkit/function-declarations-in-switch-statement-expected.txt File test/webkit/function-declarations-in-switch-statement-expected.txt (right): https://codereview.chromium.org/1628013003/diff/1/test/webkit/function-declarations-in-switch-statement-expected.txt#newcode29 test/webkit/function-declarations-in-switch-statement-expected.txt:29: FAIL -1 should be 20. Was -1. Maybe ...
4 years, 11 months ago (2016-01-25 08:47:53 UTC) #5
Dan Ehrenberg
https://codereview.chromium.org/1628013003/diff/1/test/webkit/function-declarations-in-switch-statement-expected.txt File test/webkit/function-declarations-in-switch-statement-expected.txt (right): https://codereview.chromium.org/1628013003/diff/1/test/webkit/function-declarations-in-switch-statement-expected.txt#newcode29 test/webkit/function-declarations-in-switch-statement-expected.txt:29: FAIL -1 should be 20. Was -1. On 2016/01/25 ...
4 years, 11 months ago (2016-01-25 08:52:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1628013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1628013003/1
4 years, 11 months ago (2016-01-25 08:52:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 09:02:38 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 09:03:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ef27c25e9cbc9d78abd580c3c8b7f121db69fc5
Cr-Commit-Position: refs/heads/master@{#33484}

Powered by Google App Engine
This is Rietveld 408576698