Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: build/android/device_status_check.py

Issue 16280004: Use full path to apk install script and CheckInstall apk. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/device_status_check.py
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py
index 47a63a0969a757bd75a25f25de5ba45c563c0470..d2bfb4a83eb46448552c50c68b76aabfc413b377 100755
--- a/build/android/device_status_check.py
+++ b/build/android/device_status_check.py
@@ -39,8 +39,10 @@ def DeviceInfo(serial):
setup_wizard_disabled = AdbShellCmd(
'getprop ro.setupwizard.mode') == 'DISABLED'
battery = AdbShellCmd('dumpsys battery')
- install_output = GetCmdOutput(['build/android/adb_install_apk.py', '--apk',
- 'build/android/CheckInstallApk-debug.apk'])
+ chrome_src = os.environ.get('CHROME_SRC')
Siva Chandra 2013/06/04 23:51:03 how about pylib.constants.CHROME_DIR?
+ install_output = GetCmdOutput(
+ ['%s/build/android/adb_install_apk.py' % chrome_src, '--apk',
+ '%s/build/android/CheckInstallApk-debug.apk' % chrome_src])
install_speed_found = re.findall('(\d+) KB/s', install_output)
if install_speed_found:
install_speed = int(install_speed_found[0])
@@ -183,6 +185,7 @@ def main():
parser.error('Unknown options %s' % args)
devices = android_commands.GetAttachedDevices()
types, builds, reports, errors = [], [], [], []
+ fail_step_lst = []
if devices:
types, builds, reports, errors, fail_step_lst = zip(*[DeviceInfo(dev)
for dev in devices])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698