Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1627943003: [Interpreter] Remove skips which have been fixed with Exceptions and For...Of. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove skips which have been fixed with Exceptions and For...Of. BUG=v8:4280 LOG=N Committed: https://crrev.com/9602f4b2d29537ac9d1e1a9c38f19c28308f9f9b Cr-Commit-Position: refs/heads/master@{#33489}

Patch Set 1 #

Patch Set 2 : Add back skips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -54 lines) Patch
M test/cctest/cctest.status View 4 chunks +3 lines, -6 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 15 chunks +1 line, -31 lines 0 comments Download
M test/test262/test262.status View 3 chunks +39 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627943003/1
4 years, 11 months ago (2016-01-24 22:37:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/412) v8_linux64_rel_ng_triggered on ...
4 years, 11 months ago (2016-01-24 22:52:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627943003/20001
4 years, 11 months ago (2016-01-25 10:06:13 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 10:29:11 UTC) #8
rmcilroy
Michael, these are the tests which now pass after for..of and exception support was added. ...
4 years, 11 months ago (2016-01-25 10:54:50 UTC) #10
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-25 12:14:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627943003/20001
4 years, 11 months ago (2016-01-25 12:21:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 12:22:37 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 12:23:44 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9602f4b2d29537ac9d1e1a9c38f19c28308f9f9b
Cr-Commit-Position: refs/heads/master@{#33489}

Powered by Google App Engine
This is Rietveld 408576698