Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 1627893004: Exclude all ash test on DrMemory (Closed)

Created:
4 years, 11 months ago by oshima
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude all ash test on DrMemory BUG=558054 TBR=scottmg@chromium.org Committed: https://crrev.com/144307209c8d8615bb29d8fb613367a155907c0f Cr-Commit-Position: refs/heads/master@{#371210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A tools/valgrind/gtest_exclude/ash_unittests.gtest-drmemory.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
oshima
ash_test started failing on DrMemory bot (may be because it's no longer built correctly?) I'll ...
4 years, 11 months ago (2016-01-25 08:42:36 UTC) #1
oshima
4 years, 11 months ago (2016-01-25 08:42:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627893004/1
4 years, 11 months ago (2016-01-25 08:53:00 UTC) #4
oshima
Actually, this may not work. We need to remove ash_unittests from all bots.
4 years, 11 months ago (2016-01-25 08:54:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 09:08:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/144307209c8d8615bb29d8fb613367a155907c0f Cr-Commit-Position: refs/heads/master@{#371210}
4 years, 11 months ago (2016-01-25 09:10:19 UTC) #8
scottmg
On 2016/01/25 08:42:36, oshima wrote: > ash_test started failing on DrMemory bot (may be because ...
4 years, 11 months ago (2016-01-25 18:04:06 UTC) #9
Derek Bruening
On 2016/01/25 18:04:06, scottmg wrote: > On 2016/01/25 08:42:36, oshima wrote: > > ash_test started ...
4 years, 11 months ago (2016-01-25 19:30:12 UTC) #10
scottmg
On 2016/01/25 19:30:12, Derek Bruening wrote: > On 2016/01/25 18:04:06, scottmg wrote: > > On ...
4 years, 11 months ago (2016-01-25 19:39:43 UTC) #11
oshima
4 years, 11 months ago (2016-01-25 21:18:45 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1631003002/ by oshima@chromium.org.

The reason for reverting is: This didn't help. reverting.

Powered by Google App Engine
This is Rietveld 408576698