Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issue 1627843002: [Autofill] Sanitize the credit card field value before matching against user data. (Closed)

Created:
4 years, 11 months ago by Mathieu
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Sanitize the credit card field value before matching against user data. Trim whitespace and remove stop chars. BUG=580679 TEST=AutofillManagerTest Committed: https://crrev.com/a0ce3e09b083dcc6bdee379ab4a38fc479bc09e6 Cr-Commit-Position: refs/heads/master@{#371348}

Patch Set 1 #

Patch Set 2 : clean comment #

Patch Set 3 : stop chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 2 chunks +81 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Mathieu
Hi, PTAL if you don't mind, thanks!
4 years, 11 months ago (2016-01-24 04:36:15 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm
4 years, 11 months ago (2016-01-25 22:32:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627843002/60001
4 years, 11 months ago (2016-01-25 22:38:33 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 11 months ago (2016-01-25 23:54:50 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 23:59:02 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0ce3e09b083dcc6bdee379ab4a38fc479bc09e6
Cr-Commit-Position: refs/heads/master@{#371348}

Powered by Google App Engine
This is Rietveld 408576698