Revert of List message decryption failures on chrome://gcm-internals

Revert of List message decryption failures on chrome://gcm-internals (patchset #4 id:80001 of https://codereview.chromium.org/1616113003/ )

Reason for revert:
The test added in this CL is failing fairly reliably on https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError:
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)] Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835: Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1

Original issue's description:
> List message decryption failures on chrome://gcm-internals
>
> This CL is basically just plumbing of a result code to an internal
> diagnosis page. Decryption is done at the level of the GCM Driver,
> while, for desktop, the GCMStatsRecorder is owned by the GCMClient
> several layers down, on another thread.
>
> BUG=569127
>
> Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
> Cr-Commit-Position: refs/heads/master@{#371084}

TBR=jianli@chromium.org,peter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569127
Committed: https://crrev.com/494c14efcc02bcd11c5cb48bc981590614e5c77e
Cr-Commit-Position: refs/heads/master@{#371141}

[Nico, 2016-01-23 23:03:07]

Created Revert of List message decryption failures on chrome://gcm-internals

[commit-bot: I haz the power, 2016-01-23 23:04:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627723002/1

[commit-bot: I haz the power, 2016-01-23 23:05:38]

Description was changed from

==========
Revert of List message decryption failures on chrome://gcm-internals (patchset
#4 id:80001 of https://codereview.chromium.org/1616113003/ )

Reason for revert:
The test added in this CL is failing fairly reliably on
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError: 
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)]
Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835:
Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1

Original issue's description:
> List message decryption failures on chrome://gcm-internals
> 
> This CL is basically just plumbing of a result code to an internal
> diagnosis page. Decryption is done at the level of the GCM Driver,
> while, for desktop, the GCMStatsRecorder is owned by the GCMClient
> several layers down, on another thread.
> 
> BUG=569127
> 
> Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
> Cr-Commit-Position: refs/heads/master@{#371084}

TBR=jianli@chromium.org,peter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569127
==========

to

==========
Revert of List message decryption failures on chrome://gcm-internals (patchset
#4 id:80001 of https://codereview.chromium.org/1616113003/ )

Reason for revert:
The test added in this CL is failing fairly reliably on
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError: 
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)]
Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835:
Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1

Original issue's description:
> List message decryption failures on chrome://gcm-internals
> 
> This CL is basically just plumbing of a result code to an internal
> diagnosis page. Decryption is done at the level of the GCM Driver,
> while, for desktop, the GCMStatsRecorder is owned by the GCMClient
> several layers down, on another thread.
> 
> BUG=569127
> 
> Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
> Cr-Commit-Position: refs/heads/master@{#371084}

TBR=jianli@chromium.org,peter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569127
==========

[commit-bot: I haz the power, 2016-01-23 23:05:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-23 23:06:42]

Description was changed from

==========
Revert of List message decryption failures on chrome://gcm-internals (patchset
#4 id:80001 of https://codereview.chromium.org/1616113003/ )

Reason for revert:
The test added in this CL is failing fairly reliably on
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError: 
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)]
Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835:
Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1

Original issue's description:
> List message decryption failures on chrome://gcm-internals
> 
> This CL is basically just plumbing of a result code to an internal
> diagnosis page. Decryption is done at the level of the GCM Driver,
> while, for desktop, the GCMStatsRecorder is owned by the GCMClient
> several layers down, on another thread.
> 
> BUG=569127
> 
> Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
> Cr-Commit-Position: refs/heads/master@{#371084}

TBR=jianli@chromium.org,peter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569127
==========

to

==========
Revert of List message decryption failures on chrome://gcm-internals (patchset
#4 id:80001 of https://codereview.chromium.org/1616113003/ )

Reason for revert:
The test added in this CL is failing fairly reliably on
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError:
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)]
Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835:
Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1

Original issue's description:
> List message decryption failures on chrome://gcm-internals
>
> This CL is basically just plumbing of a result code to an internal
> diagnosis page. Decryption is done at the level of the GCM Driver,
> while, for desktop, the GCMStatsRecorder is owned by the GCMClient
> several layers down, on another thread.
>
> BUG=569127
>
> Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
> Cr-Commit-Position: refs/heads/master@{#371084}

TBR=jianli@chromium.org,peter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569127

Committed: https://crrev.com/494c14efcc02bcd11c5cb48bc981590614e5c77e
Cr-Commit-Position: refs/heads/master@{#371141}
==========

[commit-bot: I haz the power, 2016-01-23 23:06:43]

Patchset 1 (id:??) landed as
https://crrev.com/494c14efcc02bcd11c5cb48bc981590614e5c77e
Cr-Commit-Position: refs/heads/master@{#371141}

[Nico, 2016-01-23 23:17:22]

This helped:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

[Peter Beverloo, 2016-01-25 10:31:06]

On 2016/01/23 23:17:22, Nico wrote:
> This helped:
>
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Sorry for the issues, and thank you for the revert! I'll investigate, land again
and keep an eye out on the bots.