Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1627703002: remove legacy defines (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove legacy defines The defines SK_SUPPORT_LEGACY_ARCTO SK_SUPPORT_LEGACY_CONIC_MEASURE SK_SUPPORT_LEGACY_DASH_MEASURE SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE have been removed from Chrome. This removes the obsolete code from Skia as well. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627703002 Committed: https://skia.googlesource.com/skia/+/a273c0f6676b261ef82bc43b0dcc53282f2bdf8c

Patch Set 1 #

Patch Set 2 : remove SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE etc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -293 lines) Patch
M include/core/SkPathMeasure.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkGeometry.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +0 lines, -174 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 1 9 chunks +0 lines, -56 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627703002/1
4 years, 11 months ago (2016-01-23 20:50:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-23 21:02:28 UTC) #5
caryclark
Verified that this does not change gm results
4 years, 11 months ago (2016-01-23 21:08:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627703002/20001
4 years, 10 months ago (2016-01-25 12:25:55 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-25 12:37:02 UTC) #11
reed1
woot! lgtm
4 years, 10 months ago (2016-01-25 14:00:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627703002/20001
4 years, 10 months ago (2016-01-25 14:32:18 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-01-25 14:33:05 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a273c0f6676b261ef82bc43b0dcc53282f2bdf8c

Powered by Google App Engine
This is Rietveld 408576698