chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc - Issue 1627543002: Anchor the infobar arrow to the LocationIconView correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

Issue 1627543002: Anchor the infobar arrow to the LocationIconView correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pkasting feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/icon_label_bubble_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

index b98ede0f8571798093fd79e123a3ccf318d4ce32..a8dc1224fda879c99215c43dc6f1668b9932346a 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

@@ -113,7 +113,7 @@ void IconLabelBubbleView::Layout() {

// this up when MD is on by default.

bool icon_has_enough_padding =

!is_extension_icon_ || ui::MaterialDesignController::IsModeMaterial();

- const int image_width = image()->GetPreferredSize().width();

+ const int image_width = image_->GetPreferredSize().width();

image_->SetBounds(std::min((width() - image_width) / 2,

GetBubbleOuterPadding(icon_has_enough_padding)),

0, image_->GetPreferredSize().width(), height());