Issue 162753002: Center and change the aspect ratio for the experimental app list. [Win]

Issue 162753002: Center and change the aspect ratio for the experimental app list. [Win] (Closed)

Created:
6 years, 10 months ago by calamity

Modified:
6 years, 10 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Center and change the aspect ratio for the experimental app list. [Win] This CL adds the enable-experimental-app-list flag which currently makes the app list launch to the center of the screen and changes the app list to display a 6 by 3 grid. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251642

Patch Set 1 #

Total comments: 2

Patch Set 2 : allow flag for linux #

Patch Set 3 : rebase #

Patch Set 4 : fix android compile #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -6 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_positioner.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/app_list_positioner.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/app_list/win/app_list_win.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/app_list/app_list_constants.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/app_list/app_list_constants.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/app_list/app_list_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/app_list/app_list_switches.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/app_list/views/app_list_folder_view.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	ui/app_list/views/apps_container_view.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	ui/app_list/views/apps_grid_view.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm https://codereview.chromium.org/162753002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/162753002/diff/1/chrome/browser/about_flags.cc#newcode1989 chrome/browser/about_flags.cc:1989: kOsCrOS | kOsWin, Can we have it on ...

6 years, 10 months ago (2014-02-14 03:03:12 UTC) #2

calamity

https://codereview.chromium.org/162753002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/162753002/diff/1/chrome/browser/about_flags.cc#newcode1989 chrome/browser/about_flags.cc:1989: kOsCrOS | kOsWin, On 2014/02/14 03:03:12, benwells wrote: > ...

6 years, 10 months ago (2014-02-17 00:13:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/162753002/120001

6 years, 10 months ago (2014-02-17 00:13:15 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-17 01:17:57 UTC) #6

commit-bot: I haz the power

Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=151282

6 years, 10 months ago (2014-02-17 01:17:57 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/162753002/370002

6 years, 10 months ago (2014-02-17 01:49:16 UTC) #9

Message was sent while issue was closed.

Change committed as 251642

Expand Messages | Collapse Messages