Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1627523002: Use the correct tabstrip height in maximized opaque frame windows in MD. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct tabstrip height in maximized opaque frame windows in MD. This is basically the same thing done in GlassBrowserFrameView::NonClientTopBorderHeight(). BUG=505805 TEST=Install https://chrome.google.com/webstore/detail/tree-branches/bgdeemcfmmabkdhbnhmkhpadancpkgol?hl=en-US . Launch with --top-chrome-md=material. Maximizes the window. The tabstrip should be tall enough to see the stroke across the top of the tabs. Committed: https://crrev.com/b5869d59ec2e1659ebfa84c66c6965eebfc06d21 Cr-Commit-Position: refs/heads/master@{#371115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
4 years, 11 months ago (2016-01-22 23:36:25 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-23 00:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627523002/1
4 years, 11 months ago (2016-01-23 00:33:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
4 years, 11 months ago (2016-01-23 00:41:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627523002/1
4 years, 11 months ago (2016-01-23 01:22:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-23 01:30:11 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 01:32:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5869d59ec2e1659ebfa84c66c6965eebfc06d21
Cr-Commit-Position: refs/heads/master@{#371115}

Powered by Google App Engine
This is Rietveld 408576698