remove obsolete UninferredClosure type

remove obsolete UninferredClosure type
fixes https://github.com/dart-lang/dev_compiler/issues/290

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/a5ee0a435e63ad1ab3b949748f0ed1fcf2c35cc2

[Jennifer Messerly, 2016-01-22 21:56:58]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-01-22 21:57:15]

The fact that this didn't affect any checker tests is a good sigh eh? :)

[vsm, 2016-01-22 22:51:29]

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (left):

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:136: }
Can you try this test with and without your change:

typedef num Num2Num(num x);

void main() {
  Num2Num g = (int x) { return x; };

  print(g(42));
}

?

I think this would trigger the uninferred closure path - it should just be a
StaticTypeError though.

[Jennifer Messerly, 2016-01-22 23:26:07]

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (left):

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:136: }
On 2016/01/22 22:51:29, vsm wrote:
> Can you try this test with and without your change:
> 
> typedef num Num2Num(num x);
> 
> void main() {
>   Num2Num g = (int x) { return x; };
> 
>   print(g(42));
> }
> 
> ?
> 
> I think this would trigger the uninferred closure path - it should just be a
> StaticTypeError though.

Without:
[warning] (int x) {return x;} ((int) → num) will need runtime check to cast to
type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)

With:
[warning] (int x) {return x;} ((int) → num) will need runtime check to cast to
type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)

[vsm, 2016-01-22 23:34:14]

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (left):

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:136: }
On 2016/01/22 23:26:07, John Messerly wrote:
> On 2016/01/22 22:51:29, vsm wrote:
> > Can you try this test with and without your change:
> > 
> > typedef num Num2Num(num x);
> > 
> > void main() {
> >   Num2Num g = (int x) { return x; };
> > 
> >   print(g(42));
> > }
> > 
> > ?
> > 
> > I think this would trigger the uninferred closure path - it should just be a
> > StaticTypeError though.
> 
> Without:
> [warning] (int x) {return x;} ((int) → num) will need runtime check to cast to
> type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)
> 
> With:
> [warning] (int x) {return x;} ((int) → num) will need runtime check to cast to
> type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)

Should be an error, not warning, right?  The runtime cast will definitely fail. 
How about folding into the previous:

if (expression is Literal || expression is FunctionExpression) {
  // fromT should be an exact type - this will almost certainly fail at
  // runtime.
 return new StaticTypeError(rules, expression, toT, reason: reason);
}

?

[Jennifer Messerly, 2016-01-22 23:49:52]

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (left):

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:136: }
On 2016/01/22 23:34:14, vsm wrote:
> On 2016/01/22 23:26:07, John Messerly wrote:
> > On 2016/01/22 22:51:29, vsm wrote:
> > > Can you try this test with and without your change:
> > > 
> > > typedef num Num2Num(num x);
> > > 
> > > void main() {
> > >   Num2Num g = (int x) { return x; };
> > > 
> > >   print(g(42));
> > > }
> > > 
> > > ?
> > > 
> > > I think this would trigger the uninferred closure path - it should just be
a
> > > StaticTypeError though.
> > 
> > Without:
> > [warning] (int x) {return x;} ((int) → num) will need runtime check to cast
to
> > type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)
> > 
> > With:
> > [warning] (int x) {return x;} ((int) → num) will need runtime check to cast
to
> > type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)
> 
> Should be an error, not warning, right?  The runtime cast will definitely
fail. 
> How about folding into the previous:
> 
> if (expression is Literal || expression is FunctionExpression) {
>   // fromT should be an exact type - this will almost certainly fail at
>   // runtime.
>  return new StaticTypeError(rules, expression, toT, reason: reason);
> }
> 
> ?

Hmmm. I did that but it didn't have any effect. It seems like this isn't the
code path we're going down in your example. Will need to investigate further.

[Jennifer Messerly, 2016-01-25 23:40:29]

PTAL

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/info.dart (left):

https://codereview.chromium.org/1627503002/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/info.dart:136: }
On 2016/01/22 23:49:52, John Messerly wrote:
> On 2016/01/22 23:34:14, vsm wrote:
> > On 2016/01/22 23:26:07, John Messerly wrote:
> > > On 2016/01/22 22:51:29, vsm wrote:
> > > > Can you try this test with and without your change:
> > > > 
> > > > typedef num Num2Num(num x);
> > > > 
> > > > void main() {
> > > >   Num2Num g = (int x) { return x; };
> > > > 
> > > >   print(g(42));
> > > > }
> > > > 
> > > > ?
> > > > 
> > > > I think this would trigger the uninferred closure path - it should just
be
> a
> > > > StaticTypeError though.
> > > 
> > > Without:
> > > [warning] (int x) {return x;} ((int) → num) will need runtime check to
cast
> to
> > > type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)
> > > 
> > > With:
> > > [warning] (int x) {return x;} ((int) → num) will need runtime check to
cast
> to
> > > type (num) → num (/Users/jmesserly/scratch/test.dart, line 5, col 15)
> > 
> > Should be an error, not warning, right?  The runtime cast will definitely
> fail. 
> > How about folding into the previous:
> > 
> > if (expression is Literal || expression is FunctionExpression) {
> >   // fromT should be an exact type - this will almost certainly fail at
> >   // runtime.
> >  return new StaticTypeError(rules, expression, toT, reason: reason);
> > }
> > 
> > ?
> 
> Hmmm. I did that but it didn't have any effect. It seems like this isn't the
> code path we're going down in your example. Will need to investigate further.

Ah, I think perhaps my rebuild just failed (I was using analyzer_cli). I've
added a test in checker_test to demonstrate the fix. Here's results after a
successful rebuild:

[error] Type check failed: (int x) {return x;} ((int) → num) is not of type
(num) → num because (int x) {return x;} cannot be typed as (num) → num
(/Users/jmesserly/scratch/test.dart, line 3, col 76)

[vsm, 2016-01-26 00:07:22]

lgtm!

[Jennifer Messerly, 2016-01-26 00:08:34]

Description was changed from

==========
remove obsolete UninferredClosure type
fixes https://github.com/dart-lang/dev_compiler/issues/290
==========

to

==========
remove obsolete UninferredClosure type
fixes https://github.com/dart-lang/dev_compiler/issues/290

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a5ee0a435e63ad1ab3b949748f0ed1fcf2c35cc2
==========

[Jennifer Messerly, 2016-01-26 00:08:35]

Committed patchset #3 (id:40001) manually as
a5ee0a435e63ad1ab3b949748f0ed1fcf2c35cc2 (presubmit successful).