Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1627483002: Clean up unnecessary codes when deleting a custom wallpaper (Closed)

Created:
4 years, 11 months ago by xdai1
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This part of code is useless (also harmless) when trying to delete a custom wallpaper in Wallpaper Picker App. WallpaperManager.removeCustomWallpaper() does all the cleanup work so this part of code becames redundant. This CL is split from https://codereview.chromium.org/1566713005 and has been lgtmed so land it directly. BUG=None TBR=bshe@chromium.org Committed: https://crrev.com/24c4ddc037619b03e7712906ef3031ee4abcb030 Cr-Commit-Position: refs/heads/master@{#371538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627483002/1
4 years, 11 months ago (2016-01-26 01:37:38 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 02:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627483002/1
4 years, 11 months ago (2016-01-26 18:03:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 18:09:14 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 18:11:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24c4ddc037619b03e7712906ef3031ee4abcb030
Cr-Commit-Position: refs/heads/master@{#371538}

Powered by Google App Engine
This is Rietveld 408576698