Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1627423002: fix arcto exception handling (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix arcto exception handling To match SVG behavior, draw a line when either radius is zero, or when the end point equals the start point. Update the GM to include these tests, and take the scale used to test it on a highres display. R=fmalita@chromium.org BUG=skia:4849 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627423002 Committed: https://skia.googlesource.com/skia/+/fc75253c82f838d0e687d05f5d7f82ebe6f26d5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M gm/arcto.cpp View 3 chunks +19 lines, -1 line 0 comments Download
M src/core/SkPath.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
Please take a look.
4 years, 11 months ago (2016-01-25 13:07:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627423002/1
4 years, 11 months ago (2016-01-25 13:08:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-25 13:08:06 UTC) #5
f(malita)
LGTM
4 years, 11 months ago (2016-01-25 13:37:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 13:39:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fc75253c82f838d0e687d05f5d7f82ebe6f26d5b

Powered by Google App Engine
This is Rietveld 408576698