Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 16274004: Adding new histograms for other devices on hisgtory page. (Closed)

Created:
7 years, 6 months ago by MAD
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Adding new histograms for other devices on hisgtory page. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203980

Patch Set 1 #

Total comments: 2

Patch Set 2 : replaced comment with unused name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
MAD
OK, now only with the new stuff... :-) Thanks! BYE MAD
7 years, 6 months ago (2013-05-31 21:48:34 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/16274004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/16274004/diff/1/tools/metrics/histograms/histograms.xml#newcode13957 tools/metrics/histograms/histograms.xml:13957: <!-- value 5 is NOT used anymore --> Was ...
7 years, 6 months ago (2013-05-31 22:50:02 UTC) #2
MAD
https://codereview.chromium.org/16274004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/16274004/diff/1/tools/metrics/histograms/histograms.xml#newcode13957 tools/metrics/histograms/histograms.xml:13957: <!-- value 5 is NOT used anymore --> On ...
7 years, 6 months ago (2013-06-01 00:24:01 UTC) #3
Alexei Svitkine (slow)
lgtm On May 31, 2013 8:24 PM, <mad@chromium.org> wrote: > > https://codereview.chromium.**org/16274004/diff/1/tools/** > metrics/histograms/histograms.**xml<https://codereview.chromium.org/16274004/diff/1/tools/metrics/histograms/histograms.xml> > ...
7 years, 6 months ago (2013-06-01 01:31:31 UTC) #4
MAD
Thanks! OWMERS review Ilya? BYE MAD...
7 years, 6 months ago (2013-06-01 12:52:04 UTC) #5
Alexei Svitkine (slow)
I'm an owner now, you can submit. On Sat, Jun 1, 2013 at 8:52 AM, ...
7 years, 6 months ago (2013-06-01 14:48:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/16274004/5001
7 years, 6 months ago (2013-06-03 14:47:01 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 6 months ago (2013-06-04 01:19:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/16274004/5001
7 years, 6 months ago (2013-06-04 15:46:27 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 16:48:26 UTC) #10
Message was sent while issue was closed.
Change committed as 203980

Powered by Google App Engine
This is Rietveld 408576698