pkg/compiler/lib/src/js_backend/runtime_types.dart - Issue 1627333002: Optimize subclass/subtype queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 1627333002: Optimize subclass/subtype queries (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Use strictSubtypeCount Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/runtime_types.dart

diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart

index 849fae3ca01a71298633aa19f7742c1e88d303d8..1501a939e5c5273a3f4ede38fd38ff5190d99505 100644

--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart

+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart

@@ -236,8 +236,7 @@ class _RuntimeTypes implements RuntimeTypes {

classesNeedingRti.add(cls);

// TODO(ngeoffray): This should use subclasses, not subtypes.

- Iterable<ClassElement> classes = compiler.world.strictSubtypesOf(cls);

- classes.forEach((ClassElement sub) {

+ compiler.world.forEachStrictSubtypeOf(cls, (ClassElement sub) {

potentiallyAddForRti(sub);

});