Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 16273010: Stop using [InterfaceName] in CSS IDL files (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, kenneth.christiansen, chromiumbugtracker_adobe.com, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears, lgombos
Visibility:
Public.

Description

Stop using [InterfaceName] in CSS IDL files [InterfaceName] was deprecated in favor of [ImplementedAs] extended IDL attribute. This patch replaces uses of [InterfaceName] by [ImplementedAs] in CSS IDL files and renames the files to match the name exposed to JavaScript. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152206

Patch Set 1 #

Patch Set 2 : Add missing changes to custom files #

Patch Set 3 : Rebase on master #

Patch Set 4 : Fix merge conflict for CSSViewportRule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -444 lines) Patch
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
D Source/core/css/CSSFilterRule.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/css/CSSFilterValue.idl View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/css/CSSKeyframeRule.idl View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/core/css/CSSKeyframesRule.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/css/CSSMatrix.idl View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/css/CSSMixFunctionValue.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/core/css/CSSRegionRule.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/css/CSSTransformValue.idl View 1 chunk +0 lines, -61 lines 0 comments Download
A + Source/core/css/WebKitCSSFilterRule.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/WebKitCSSFilterValue.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/WebKitCSSKeyframeRule.idl View 1 chunk +2 lines, -3 lines 0 comments Download
A + Source/core/css/WebKitCSSKeyframesRule.idl View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/core/css/WebKitCSSMatrix.idl View 2 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/css/WebKitCSSMixFunctionValue.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/WebKitCSSRegionRule.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/WebKitCSSTransformValue.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-10 13:59:34 UTC) #1
haraken
LGTM
7 years, 6 months ago (2013-06-10 14:01:56 UTC) #2
haraken
Why did you close the issue?
7 years, 6 months ago (2013-06-10 14:02:43 UTC) #3
do-not-use
On 2013/06/10 14:02:43, haraken wrote: > Why did you close the issue? Sorry, it is ...
7 years, 6 months ago (2013-06-10 14:17:03 UTC) #4
haraken
Still LGTM.
7 years, 6 months ago (2013-06-10 14:21:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16273010/4001
7 years, 6 months ago (2013-06-10 14:26:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=12160
7 years, 6 months ago (2013-06-10 16:39:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16273010/4001
7 years, 6 months ago (2013-06-10 20:07:57 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/core/css/WebKitCSSViewportRule.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source/core/css/WebKitCSSViewportRule.idl ...
7 years, 6 months ago (2013-06-10 20:08:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16273010/21001
7 years, 6 months ago (2013-06-11 06:19:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=9295
7 years, 6 months ago (2013-06-11 07:52:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16273010/21001
7 years, 6 months ago (2013-06-11 08:26:01 UTC) #12
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 09:36:15 UTC) #13
Message was sent while issue was closed.
Change committed as 152206

Powered by Google App Engine
This is Rietveld 408576698