[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=

Committed: https://crrev.com/2166bd8ce51f83693fa88f590b82d24a1856e0e7
Cr-Commit-Position: refs/heads/master@{#33797}

[ahaas, 2016-01-29 10:45:07]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-01-29 10:45:08]

https://codereview.chromium.org/1627263002/diff/1/src/compiler/ia32/code-gene...
File src/compiler/ia32/code-generator-ia32.cc (right):

https://codereview.chromium.org/1627263002/diff/1/src/compiler/ia32/code-gene...
src/compiler/ia32/code-generator-ia32.cc:750: __ Move(kScratchDoubleReg,
-2147483648.0f);
You could use static_cast<float>(INT32_MIN) here, that would be easier to
understand.

https://codereview.chromium.org/1627263002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1627263002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-machops.cc:4143: FOR_UINT32_INPUTS(i) {
Could you also run tests for FOR_FLOAT32_INPUTS where the value is within
uint32_t range?

[ahaas, 2016-02-03 13:44:38]

ahaas@chromium.org changed reviewers:
+ v8-arm-ports@googlegroups.com

[ahaas, 2016-02-03 13:47:02]

lgtm

https://codereview.chromium.org/1627263002/diff/20001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1627263002/diff/20001/test/cctest/compiler/te...
test/cctest/compiler/test-run-machops.cc:4154: if (*i <=
static_cast<float>(std::numeric_limits<uint32_t>::max()) &&
Nit: I think you should use either UINT32_MAX or
std::numeric_limits<uint32_t>::max(), but not both in the same test.

[Jing, 2016-02-04 02:36:21]

The CQ bit was checked by jing.bao@intel.com

[Jing, 2016-02-04 02:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1627263002/#ps40001
(title: "Andreas' comment")

[commit-bot: I haz the power, 2016-02-04 02:36:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627263002/40001

[Jing, 2016-02-04 02:37:26]

The CQ bit was unchecked by jing.bao@intel.com

[Jing, 2016-02-04 03:09:17]

The CQ bit was checked by jing.bao@intel.com

[commit-bot: I haz the power, 2016-02-04 03:09:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627263002/40001

[commit-bot: I haz the power, 2016-02-04 03:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 03:12:12]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10491)

[Jing, 2016-02-04 03:46:59]

Description was changed from

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=
==========

to

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=
==========

[Jing, 2016-02-04 03:46:59]

jing.bao@intel.com changed reviewers:
+ titzer@chromium.org

[Jing, 2016-02-04 07:34:54]

@titzer, seems that LGTM from the OWNER is needed.

[ahaas, 2016-02-04 09:14:05]

On 2016/02/04 at 07:34:54, jing.bao wrote:
> @titzer, seems that LGTM from the OWNER is needed.

Did you check that the disassembler works for the generated code?

[titzer, 2016-02-04 09:19:29]

On 2016/02/04 09:14:05, ahaas wrote:
> On 2016/02/04 at 07:34:54, jing.bao wrote:
> > @titzer, seems that LGTM from the OWNER is needed.
> 
> Did you check that the disassembler works for the generated code?

lgtm

[Jing, 2016-02-05 02:10:48]

On 2016/02/04 09:14:05, ahaas wrote:
> On 2016/02/04 at 07:34:54, jing.bao wrote:
> > @titzer, seems that LGTM from the OWNER is needed.
> 
> Did you check that the disassembler works for the generated code?

The --print_all_code flag works fine for the newly added arm instruction. Maybe
v8-arm-ports would like to help add formal assembler/disassembler tests?

[jbramley, 2016-02-05 09:44:58]

On 2016/02/05 02:10:48, Jing wrote:
> On 2016/02/04 09:14:05, ahaas wrote:
> > On 2016/02/04 at 07:34:54, jing.bao wrote:
> > > @titzer, seems that LGTM from the OWNER is needed.
> > 
> > Did you check that the disassembler works for the generated code?
> 
> The --print_all_code flag works fine for the newly added arm instruction.
Maybe
> v8-arm-ports would like to help add formal assembler/disassembler tests?

I'll add some in a separate patch. Thanks for pointing this out!

[Jing, 2016-02-06 01:33:34]

The CQ bit was checked by jing.bao@intel.com

[commit-bot: I haz the power, 2016-02-06 01:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627263002/40001

[commit-bot: I haz the power, 2016-02-06 18:08:58]

Description was changed from

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=
==========

to

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=
==========

[commit-bot: I haz the power, 2016-02-06 18:08:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-06 18:09:46]

Description was changed from

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=
==========

to

==========
[turbofan] Add TruncateFloat32ToUint32 operator to Turbofan.

BUG=

Committed: https://crrev.com/2166bd8ce51f83693fa88f590b82d24a1856e0e7
Cr-Commit-Position: refs/heads/master@{#33797}
==========

[commit-bot: I haz the power, 2016-02-06 18:09:47]

Patchset 3 (id:??) landed as
https://crrev.com/2166bd8ce51f83693fa88f590b82d24a1856e0e7
Cr-Commit-Position: refs/heads/master@{#33797}