Fix link header preload on subresources

Fix link header preload on subresources

Link header preloads were not working when sent over subresources.
This CL fixes that.

BUG=568025
Committed: https://crrev.com/48ac6111e9d40f72ee981a9388cf89a96b757f69
Cr-Commit-Position: refs/heads/master@{#372024}

[Yoav Weiss, 2016-01-24 21:22:07]

yoav@yoav.ws changed reviewers:
+ japhet@chromium.org

[Yoav Weiss, 2016-01-24 21:22:07]

Hey Nate :)

A small bug fix for preload link headers. Mind taking a look?

[Nate Chapin, 2016-01-25 21:50:10]

Seems reasonable, just a bit of nitpicking :)

https://codereview.chromium.org/1627203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (left):

https://codereview.chromium.org/1627203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:254:
LinkLoader::loadLinkFromHeader(response.httpHeaderField(HTTPNames::Link),
frame()->document(), NetworkHintsInterfaceImpl(),
LinkLoader::DoNotLoadResources);
Maybe keep the loadLinkFromHeader() call here, and just vary the
DoNotLoadResources/LoadResourcesAndPreconnect, with a comment explaining why.

[Yoav Weiss, 2016-01-25 22:12:45]

https://codereview.chromium.org/1627203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (left):

https://codereview.chromium.org/1627203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:254:
LinkLoader::loadLinkFromHeader(response.httpHeaderField(HTTPNames::Link),
frame()->document(), NetworkHintsInterfaceImpl(),
LinkLoader::DoNotLoadResources);
On 2016/01/25 21:50:10, Nate Chapin wrote:
> Maybe keep the loadLinkFromHeader() call here, and just vary the
> DoNotLoadResources/LoadResourcesAndPreconnect, with a comment explaining why.

Yeah. Certainly DRYer to have a single call. I'll move it after the condition,
so we won't have to branch twice.

[Yoav Weiss, 2016-01-26 05:12:04]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 05:12:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627203002/40001

[commit-bot: I haz the power, 2016-01-26 06:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 06:29:56]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-01-27 22:26:31]

lgtm

[Yoav Weiss, 2016-01-27 22:29:10]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2016-01-27 22:29:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627203002/40001

[commit-bot: I haz the power, 2016-01-28 00:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:07:26]

Exceeded global retry quota

[Yoav Weiss, 2016-01-28 05:37:28]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2016-01-28 05:37:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627203002/40001

[commit-bot: I haz the power, 2016-01-28 05:43:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 05:44:15]

Description was changed from

==========
Fix link header preload on subresources

Link header preloads were not working when sent over subresources.
This CL fixes that.

BUG=568025
==========

to

==========
Fix link header preload on subresources

Link header preloads were not working when sent over subresources.
This CL fixes that.

BUG=568025

Committed: https://crrev.com/48ac6111e9d40f72ee981a9388cf89a96b757f69
Cr-Commit-Position: refs/heads/master@{#372024}
==========

[commit-bot: I haz the power, 2016-01-28 05:44:21]

Patchset 3 (id:??) landed as
https://crrev.com/48ac6111e9d40f72ee981a9388cf89a96b757f69
Cr-Commit-Position: refs/heads/master@{#372024}