Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 16272007: Fix the shared_library build on Linux. (Closed)

Created:
7 years, 6 months ago by wtc
Modified:
7 years, 6 months ago
Reviewers:
digit, Yaron, digit1
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the shared_library build on Linux. Two source files need to be excluded for x86_64 because they are replaced by openssl/crypto/bn/asm/x86_64-gcc.c and openssl/crypto/rc4/asm/rc4-x86_64.S. R=yfriedman@chromium.org,digit@chromium.org BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a patch file to patches.chromium #

Patch Set 3 : Add a patch file to patches.chromium #

Patch Set 4 : Describe the patch in README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M README.chromium View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M openssl.gyp View 2 chunks +2 lines, -6 lines 0 comments Download
M openssl.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M openssl/Crypto-config.mk View 1 1 chunk +2 lines, -0 lines 0 comments Download
M openssl/openssl.config View 1 1 chunk +2 lines, -0 lines 0 comments Download
A patches.chromium/x86_64_source_excludes.patch View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wtc
Please review. This CL is a follow-up to https://codereview.chromium.org/13979005/
7 years, 6 months ago (2013-05-31 21:52:53 UTC) #1
digit
https://codereview.chromium.org/16272007/diff/1/openssl.gypi File openssl.gypi (right): https://codereview.chromium.org/16272007/diff/1/openssl.gypi#newcode624 openssl.gypi:624: 'openssl/crypto/bn/bn_asm.c', this is an auto-generated here, modifying this by ...
7 years, 6 months ago (2013-05-31 22:06:46 UTC) #2
wtc
digit: please review patch set 3. (Patch sets 2 and 3 are the same.) I ...
7 years, 6 months ago (2013-05-31 22:27:22 UTC) #3
digit
Very nice, thank you. LGTM Can I ask you to update README.Chromium with a small ...
7 years, 6 months ago (2013-05-31 23:02:53 UTC) #4
digit
Arf, hit "Send" too soon :-) I was saying: I'll probably port it to AOSP ...
7 years, 6 months ago (2013-05-31 23:03:27 UTC) #5
wtc
On 2013/05/31 23:02:53, digit wrote: > > Can I ask you to update README.Chromium with ...
7 years, 6 months ago (2013-05-31 23:12:41 UTC) #6
digit
thanks, lgtm.
7 years, 6 months ago (2013-05-31 23:50:17 UTC) #7
Yaron
lgtm
7 years, 6 months ago (2013-06-01 00:18:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/16272007/10001
7 years, 6 months ago (2013-06-01 01:06:38 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-01 01:06:55 UTC) #10
Message was sent while issue was closed.
Change committed as 203545

Powered by Google App Engine
This is Rietveld 408576698