Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1627193004: MacViews: Implement BridgedNativeWidget::PrepareForLayerBoundsChange(). (Closed)

Created:
4 years, 11 months ago by Andrey Kraynov
Modified:
4 years, 11 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Implement BridgedNativeWidget::PrepareForLayerBoundsChange(). Just removed NOTIMPLEMENTED from BridgedNativeWidget::PrepareForLayerBoundsChange() function. BUG=454698 Committed: https://crrev.com/b38868347ad9676a32deceaecd59dc0f0725e636 Cr-Commit-Position: refs/heads/master@{#371763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/views/cocoa/bridged_native_widget.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Andrey Kraynov
Hi! Here I just removed NOTIMPLEMENTED macro. As I can see from quick debug output, ...
4 years, 11 months ago (2016-01-25 12:56:11 UTC) #2
tapted
lgtm - I think this is fine since it's makes a lot of spam. It's ...
4 years, 11 months ago (2016-01-27 04:44:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627193004/1
4 years, 11 months ago (2016-01-27 09:06:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 09:34:50 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 09:36:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38868347ad9676a32deceaecd59dc0f0725e636
Cr-Commit-Position: refs/heads/master@{#371763}

Powered by Google App Engine
This is Rietveld 408576698