[Smart Lock, UI] Display origin in account chooser dialog.

[Smart Lock, UI] Display origin in account chooser dialog.

BUG=454815
Committed: https://crrev.com/2ca77c1b78d7cf0154300e7d508d92ab47c4b944
Cr-Commit-Position: refs/heads/master@{#371488}

[melandory, 2016-01-25 08:31:05]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2016-01-25 08:31:06]

Hi Vaclav,

PTAL at changes in password_manager/

[melandory, 2016-01-25 08:32:02]

On 2016/01/25 08:31:06, melandory wrote:
> Hi Vaclav,
> 
> PTAL at changes in password_manager/

* components/password_manager/
* chrome/browser/password_manager/

[vabr (Chromium), 2016-01-25 10:15:31]

components/password_manager/ and  chrome/browser/password_manager/ LGTM.

Cheers,
Vaclav

https://codereview.chromium.org/1627193003/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/account_chooser_dialog_android.cc (right):

https://codereview.chromium.org/1627193003/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/account_chooser_dialog_android.cc:152: env,
password_manager::GetShownOrigin(origin_, ""))
"" -> std::string()
(The default constructor is more efficient.)

[melandory, 2016-01-25 14:29:13]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2016-01-25 14:29:13]

dfalcantara@chromium.org: Please review changes in 

chrome/android/java/res/layout/account_chooser_dialog_title.xml

chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java

[gone, 2016-01-25 18:36:28]

https://chromiumcodereview.appspot.com/1627193003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
(right):

https://chromiumcodereview.appspot.com/1627193003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java:140:
// TODO(melandory): add support for showing site origin in the title.
Is your TODO still relevant?

[gone, 2016-01-25 18:36:31]

lgtm

[melandory, 2016-01-26 09:38:17]

The CQ bit was unchecked by melandory@chromium.org

[melandory, 2016-01-26 09:38:17]

The CQ bit was checked by melandory@chromium.org

[melandory, 2016-01-26 09:38:25]

The CQ bit was unchecked by melandory@chromium.org

[commit-bot: I haz the power, 2016-01-26 09:38:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627193003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627193003/1

[melandory, 2016-01-26 09:46:19]

https://codereview.chromium.org/1627193003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
(right):

https://codereview.chromium.org/1627193003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java:140:
// TODO(melandory): add support for showing site origin in the title.
On 2016/01/25 18:36:28, dfalcantara wrote:
> Is your TODO still relevant?

Done.

https://codereview.chromium.org/1627193003/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/account_chooser_dialog_android.cc (right):

https://codereview.chromium.org/1627193003/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/account_chooser_dialog_android.cc:152: env,
password_manager::GetShownOrigin(origin_, ""))
On 2016/01/25 10:15:30, vabr (Chromium) wrote:
> "" -> std::string()
> (The default constructor is more efficient.)

Done.

[melandory, 2016-01-26 09:46:31]

The CQ bit was checked by melandory@chromium.org

[melandory, 2016-01-26 09:46:32]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1627193003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-26 09:46:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627193003/20001

[commit-bot: I haz the power, 2016-01-26 11:00:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 11:01:02]

Description was changed from

==========
[Smart Lock, UI] Display origin in account chooser dialog.

BUG=454815
==========

to

==========
[Smart Lock, UI] Display origin in account chooser dialog.

BUG=454815

Committed: https://crrev.com/2ca77c1b78d7cf0154300e7d508d92ab47c4b944
Cr-Commit-Position: refs/heads/master@{#371488}
==========

[commit-bot: I haz the power, 2016-01-26 11:01:03]

Patchset 2 (id:??) landed as
https://crrev.com/2ca77c1b78d7cf0154300e7d508d92ab47c4b944
Cr-Commit-Position: refs/heads/master@{#371488}