[Mac] Fix duplicate "Enter Full Screen" item in view menu.

[Mac] Fix duplicate "Enter Full Screen" item in view menu.

Changes the action of our full screen item to -toggleFullScreen:
which we already handle. Previously, Cocoa would add an extra
"Enter Full Screen" item if it didn't find an existing one with
the -toggleFullScreen: action.

BUG=538872
TEST=Open View menu from menubar. There should be only one "Enter
Full Screen" item and it should work as expected.

Committed: https://crrev.com/b88a2dc5ae6d9b4bdeff2730fac2ff46ae6a2fca
Cr-Commit-Position: refs/heads/master@{#371305}

[Alexei Svitkine (slow), 2016-01-25 00:11:22]

asvitkine@chromium.org changed reviewers:
+ erikchen@chromium.org

[Alexei Svitkine (slow), 2016-01-25 00:11:22]

PTAL.

BTW, I get a warning:

"XIB files need to be saved on Mac OS X 10.9.5"

Should we bump that check to support 10.11?

[erikchen, 2016-01-25 14:55:07]

On 2016/01/25 00:11:22, Alexei Svitkine (very slow) wrote:
> PTAL.
> 
> BTW, I get a warning:
> 
> "XIB files need to be saved on Mac OS X 10.9.5"
> 
> Should we bump that check to support 10.11?

We need to have xib files that can be compiled by the official build bot, which
I believe is still on 10.9.5, Xcode 5.1.1. I have a 10.9 machine back in MTV - I
can redo this CL with that machine when I get back.

[Alexei Svitkine (slow), 2016-01-25 17:31:55]

Patchset #2 (id:20001) has been deleted

[Alexei Svitkine (slow), 2016-01-25 17:32:01]

Patchset #2 (id:40001) has been deleted

[Alexei Svitkine (slow), 2016-01-25 17:32:35]

PTAL, I've edited the file manually now to preserve the 10.9 format, but
verified that the change is still working correctly.

[erikchen, 2016-01-25 19:30:32]

lgtm

thanks, lgtm

[Alexei Svitkine (slow), 2016-01-25 19:33:10]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-01-25 19:39:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1627163003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1627163003/60001

[commit-bot: I haz the power, 2016-01-25 20:42:35]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-01-25 20:43:59]

Description was changed from

==========
[Mac] Fix duplicate "Enter Full Screen" item in view menu.

Changes the action of our full screen item to -toggleFullScreen:
which we already handle. Previously, Cocoa would add an extra
"Enter Full Screen" item if it didn't find an existing one with
the -toggleFullScreen: action.

BUG=538872
TEST=Open View menu from menubar. There should be only one "Enter
Full Screen" item and it should work as expected.
==========

to

==========
[Mac] Fix duplicate "Enter Full Screen" item in view menu.

Changes the action of our full screen item to -toggleFullScreen:
which we already handle. Previously, Cocoa would add an extra
"Enter Full Screen" item if it didn't find an existing one with
the -toggleFullScreen: action.

BUG=538872
TEST=Open View menu from menubar. There should be only one "Enter
Full Screen" item and it should work as expected.

Committed: https://crrev.com/b88a2dc5ae6d9b4bdeff2730fac2ff46ae6a2fca
Cr-Commit-Position: refs/heads/master@{#371305}
==========

[commit-bot: I haz the power, 2016-01-25 20:43:59]

Patchset 2 (id:??) landed as
https://crrev.com/b88a2dc5ae6d9b4bdeff2730fac2ff46ae6a2fca
Cr-Commit-Position: refs/heads/master@{#371305}