Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1627163003: [Mac] Fix duplicate "Enter Full Screen" item in view menu. (Closed)

Created:
4 years, 11 months ago by Alexei Svitkine (slow)
Modified:
4 years, 11 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix duplicate "Enter Full Screen" item in view menu. Changes the action of our full screen item to -toggleFullScreen: which we already handle. Previously, Cocoa would add an extra "Enter Full Screen" item if it didn't find an existing one with the -toggleFullScreen: action. BUG=538872 TEST=Open View menu from menubar. There should be only one "Enter Full Screen" item and it should work as expected. Committed: https://crrev.com/b88a2dc5ae6d9b4bdeff2730fac2ff46ae6a2fca Cr-Commit-Position: refs/heads/master@{#371305}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/nibs/MainMenu.xib View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Alexei Svitkine (slow)
PTAL. BTW, I get a warning: "XIB files need to be saved on Mac OS ...
4 years, 11 months ago (2016-01-25 00:11:22 UTC) #2
erikchen
On 2016/01/25 00:11:22, Alexei Svitkine (very slow) wrote: > PTAL. > > BTW, I get ...
4 years, 11 months ago (2016-01-25 14:55:07 UTC) #3
Alexei Svitkine (slow)
PTAL, I've edited the file manually now to preserve the 10.9 format, but verified that ...
4 years, 11 months ago (2016-01-25 17:32:35 UTC) #6
erikchen
lgtm thanks, lgtm
4 years, 11 months ago (2016-01-25 19:30:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1627163003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1627163003/60001
4 years, 11 months ago (2016-01-25 19:39:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 11 months ago (2016-01-25 20:42:35 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 20:43:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b88a2dc5ae6d9b4bdeff2730fac2ff46ae6a2fca
Cr-Commit-Position: refs/heads/master@{#371305}

Powered by Google App Engine
This is Rietveld 408576698