chrome/browser/ui/website_settings/permission_bubble_manager.cc - Issue 162713003: [WebsiteSettings] Set view to null on manager to ensure no stale access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 162713003: [WebsiteSettings] Set view to null on manager to ensure no stale access. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Set view delegate null on mgr destroy Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.h ('k') | chrome/browser/ui/website_settings/permission_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

index 990d124df440414409cc28736b54a2edc59db926..c6d4141a0bea6f5012f241766a01bce1db307bdc 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

@@ -90,7 +90,13 @@ PermissionBubbleManager::PermissionBubbleManager(

false));

}

-PermissionBubbleManager::~PermissionBubbleManager() {}

+PermissionBubbleManager::~PermissionBubbleManager() {

+ if (view_ != NULL) {

+ view_->SetDelegate(NULL);

+ view_->Hide();

+ bubble_showing_ = false;

+ }

void PermissionBubbleManager::DidFinishLoad(

int64 frame_id,