Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3821)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 162713003: [WebsiteSettings] Set view to null on manager to ensure no stale access. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Set view delegate null on mgr destroy Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/permission_bubble_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index 6171cd915c9c41bc322fe2706be3c86c4a3c879b..850544b61dcd24aba3330be1bb8bae9f5ff6c3a3 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -43,7 +43,7 @@ class PermissionsBubbleDelegateView : public views::BubbleDelegateView,
bool customization_mode);
virtual ~PermissionsBubbleDelegateView();
- void ResetOwner();
+ void Close();
void SizeToContents();
// BubbleDelegateView:
@@ -192,8 +192,9 @@ PermissionsBubbleDelegateView::~PermissionsBubbleDelegateView() {
owner_->Closing();
}
-void PermissionsBubbleDelegateView::ResetOwner() {
+void PermissionsBubbleDelegateView::Close() {
owner_ = NULL;
+ GetWidget()->Close();
}
bool PermissionsBubbleDelegateView::ShouldShowCloseButton() const {
@@ -242,7 +243,10 @@ PermissionBubbleViewViews::PermissionBubbleViewViews(views::View* anchor_view)
delegate_(NULL),
bubble_delegate_(NULL) {}
-PermissionBubbleViewViews::~PermissionBubbleViewViews() {}
+PermissionBubbleViewViews::~PermissionBubbleViewViews() {
+ if (delegate_)
+ delegate_->SetView(NULL);
+}
void PermissionBubbleViewViews::SetDelegate(Delegate* delegate) {
delegate_ = delegate;
@@ -252,10 +256,8 @@ void PermissionBubbleViewViews::Show(
const std::vector<PermissionBubbleRequest*>& requests,
const std::vector<bool>& values,
bool customization_mode) {
- if (bubble_delegate_ != NULL) {
- bubble_delegate_->ResetOwner();
- bubble_delegate_->StartFade(false);
- }
+ if (bubble_delegate_ != NULL)
+ bubble_delegate_->Close();
PermissionsBubbleDelegateView* bubble_delegate =
new PermissionsBubbleDelegateView(anchor_view_, this,
@@ -269,8 +271,8 @@ void PermissionBubbleViewViews::Show(
void PermissionBubbleViewViews::Hide() {
if (bubble_delegate_) {
- bubble_delegate_->ResetOwner();
- bubble_delegate_->StartFade(false);
+ bubble_delegate_->Close();
+ bubble_delegate_ = NULL;
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/permission_bubble_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698