Drag on linux

ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h"
 
 #include <X11/Xlib.h>
 // Get rid of a macro from Xlib.h that conflicts with Aura's RootWindow class.
 #undef RootWindow
 
@@ skipping 27 matching lines @@
 
   // Note: the escape key is handled in the tab drag controller, which has
   // keyboard focus even though we took pointer grab.
   switch (xev->type) {
     case MotionNotify: {
       delegate_->OnMouseMovement(&xev->xmotion);
       break;
     }
     case ButtonPress:
     case ButtonRelease: {
-      EndMoveLoop();
+      delegate_->OnMouseReleased();

[Daniel Erat, 2013/06/17 22:09:57]

is it intentional that this is also called for button presses (presumably
referring to other buttons)?

[Elliot Glaysher, 2013/06/18 00:06:39]

Removed ButtonPress. (The historical reasons here have to do with what should
happen when another button is pressed while dragging a tab; I've filled
crbug.com/251040)

       break;
     }
   }
 
   return true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopRootWindowHostLinux, aura::client::WindowMoveClient implementation:
 
@@ skipping 70 matching lines @@
   base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(
       grab_input_window_);
   delegate_->OnMoveLoopEnded();
   XDestroyWindow(display, grab_input_window_);
 
   in_move_loop_ = false;
   quit_closure_.Run();
 }
 
 }  // namespace views